zed icon indicating copy to clipboard operation
zed copied to clipboard

Inline diff viewer closing itself

Open alexkirsz opened this issue 1 year ago • 7 comments

Check for existing issues

  • [X] Completed

Describe the bug / provide steps to reproduce it

When I try to show an inline diff, the diff viewer closes itself after less than a second.

To open the inline diff, I click on the fat yellow/green/red margin.

As far as I know, this bug was already there last time I tried Zed (~3 months ago).

https://github.com/user-attachments/assets/95594e11-d273-4a46-8426-7a7f2db1f868

Environment

Zed: v0.156.0 (Zed) OS: macOS 14.6.1 Memory: 32 GiB Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your Zed.log file to this issue.

No response

alexkirsz avatar Oct 10 '24 08:10 alexkirsz

Might be related to

  • https://github.com/zed-industries/zed/issues/19019

alexkirsz avatar Oct 10 '24 12:10 alexkirsz

This sounds really silly, but do you perhaps have a second (maybe wireless) keyboard with something pushing the Escape key?

notpeter avatar Oct 10 '24 13:10 notpeter

@notpeter I have two keyboards: my MBP's keyboard, which I don't use, and my wireless keyboard, which is how I interact with the editor. I don't think the Escape key is being pressed spuriously, as it would likely show in other parts of my workflow, but I will check.

alexkirsz avatar Oct 10 '24 14:10 alexkirsz

Just had this issue occur again, and I can confirm that my escape key wasn't being pressed.

alexkirsz avatar Oct 30 '24 17:10 alexkirsz

Is this still happening for you @alexkirsz?

JosephTLyons avatar Feb 12 '25 02:02 JosephTLyons

Haven’t had this issue occur in a while, closing.

alexkirsz avatar Feb 12 '25 09:02 alexkirsz

This happened again today, reopening.

Zed: v0.172.11 (Zed)
OS: macOS 15.3.0
Memory: 48 GiB
Architecture: aarch64

https://github.com/user-attachments/assets/b9982544-7838-418c-95c9-6b63dc97aec3

alexkirsz avatar Feb 18 '25 09:02 alexkirsz

Hi there! 👋 We're working to clean up our issue tracker by closing older bugs that might not be relevant anymore. If you are able to reproduce this issue in the latest version of Zed, please let us know by commenting on this issue, and it will be kept open. If you can't reproduce it, feel free to close the issue yourself. Otherwise, it will close automatically in 14 days. Thanks for your help!

github-actions[bot] avatar Nov 19 '25 07:11 github-actions[bot]

Hey @alexkirsz , has this happened again? Sorry, I know it's been a minute, we're working on diff improvements now and haven't trouble reproducing.

katie-z-geer avatar Dec 05 '25 22:12 katie-z-geer