zed icon indicating copy to clipboard operation
zed copied to clipboard

terminal: Fix Alacritty TERM handling

Open liam-fitzgerald opened this issue 1 year ago • 3 comments

setup_env modifies the current process's environment, which we are ignoring in favour of the env variable. Instead, we copy over the relevant variables from the current environment after modification so that we don't have to re-implement the logic.

Closes #17991

Release Notes:

  • N/A

liam-fitzgerald avatar Oct 01 '24 21:10 liam-fitzgerald

We require contributors to sign our Contributor License Agreement, and we don't have @liam-fitzgerald on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

cla-bot[bot] avatar Oct 01 '24 21:10 cla-bot[bot]

@cla-bot check

liam-fitzgerald avatar Oct 01 '24 21:10 liam-fitzgerald

The cla-bot has been summoned, and re-checked this pull request!

cla-bot[bot] avatar Oct 01 '24 21:10 cla-bot[bot]

A bit surprising to see this small thing getting stale, will close this to keep the queue cleaner.

SomeoneToIgnore avatar Nov 01 '24 13:11 SomeoneToIgnore