AddSelectionAbove and AddSelectionBelow remove selection instead of just adding

[paolodelfino]

trafficstars

Check for existing issues

• [X] Completed

Describe the bug / provide steps to reproduce it

AddSelectionAbove and AddSelectionBelow remove the entire selection if you don't go in the same direction. I mean, let's say you first call AddSelectionAbove and then you also want to select below, therefore you AddSelectionbBelow, but this time it will not only add the selection below but also remove the selection above.

I find it a bug because it adds the extra thing of a cancellation that the name doesn't specify. If I want to revert by decision, in this case, I can for example press escape.

I usually use the correct behavior of this functions in vscode in cases like:

#define MACRO\
do {\
    printf("Hello, World!\n");\
} while (0)

In this case I position myself to the longest line and add the selection above and below then put spaces and back delete and achieve something like:

#define MACRO                   \
do {                                      \
    printf("Hello, World!\n"); \
} while (0)

The above is not possible in zed because of #17147 and #17142

Environment

Zed: v0.152.0 (Zed Dev cdaa80fefbfd8e023f76849a99440aa4c52cfbc8) OS: Windows 10.0.22631 Memory: 15.9 GiB Architecture: x86_64 GPU: NVIDIA GeForce RTX 2060 || NVIDIA || 560.94

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your Zed.log file to this issue.

Zed.log

[notpeter]

Can you do me a favor and edit the description to include concise step-by-step reproduction steps, consolidate #17142 #17147 and #17148 into a single issue and close the others?

I think you have a valid issue but I'm having trouble keeping track and I'd like discussion to occur in a single thread. Thanks.

[paolodelfino]

What should the title be?

Can you do me a favor and edit the description to include concise step-by-step reproduction steps, consolidate #17142 #17147 and #17148 into a single issue and close the others?

I think you have a valid issue but I'm having trouble keeping track and I'd like discussion to occur in a single thread. Thanks.

[github-actions[bot]]

Hi there! 👋 We're working to clean up our issue tracker by closing older issues that might not be relevant anymore. If you are able to reproduce this issue in the latest version of Zed, please let us know by commenting on this issue, and we will keep it open. If you can't reproduce it, feel free to close the issue yourself. Otherwise, we'll close it in 7 days. Thanks for your help!

[github-actions[bot]]

Hi there! 👋 We're working to clean up our issue tracker by closing older bugs that might not be relevant anymore. If you are able to reproduce this issue in the latest version of Zed, please let us know by commenting on this issue, and it will be kept open. If you can't reproduce it, feel free to close the issue yourself. Otherwise, it will close automatically in 14 days. Thanks for your help!