zed icon indicating copy to clipboard operation
zed copied to clipboard

[Windows?] Hue shift on semi-transparent layers

Open Huliiiiii opened this issue 1 year ago β€’ 2 comments

Check for existing issues

  • [X] Completed

Describe the bug / provide steps to reproduce it

VsCode: image image image

Zed: image image image

We can notice that on Zed, the hue of semi-transparent layers is skewed towards the higher value color, and this shouldn't happen.

Environment

Zed: v0.151.0 (Zed Dev 28568429aa26260f273b86294b8f5d1bc5d95b7b) OS: Windows 10.0.22631 Memory: 31.9 GiB Architecture: x86_64 GPU: NVIDIA GeForce RTX 2060 || NVIDIA || 556.12

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your Zed.log file to this issue.

Zed.log

Huliiiiii avatar Aug 23 '24 02:08 Huliiiiii

It seems that the Blade rendering backend has some color issues on Windows. I tested your #0080ff80 example using the One Light theme, and here’s what I observed:

  • Blade backend: The color appears as #b7c9fc
  • On macOS: The color appears as #7cbdfd
  • In my DX11 implementation from #13684: The color appears as #7dbdfd

The DX11 backend is very close to the macOS results, whereas both differ noticeably from Blade.

JunkuiZhang avatar Aug 24 '24 18:08 JunkuiZhang

This is because the Blade backend uses Linear instead of sRGB:

  • https://github.com/zed-industries/zed/issues/13564

apricotbucket28 avatar Aug 25 '24 14:08 apricotbucket28

Hi there! πŸ‘‹ We're working to clean up our issue tracker by closing older issues that might not be relevant anymore. If you are able to reproduce this issue in the latest version of Zed, please let us know by commenting on this issue, and we will keep it open. If you can't reproduce it, feel free to close the issue yourself. Otherwise, we'll close it in 7 days. Thanks for your help!

github-actions[bot] avatar Mar 18 '25 11:03 github-actions[bot]

Still happening on https://github.com/zed-industries/zed/commit/387ee46c466f6e2c736e35fb823fea1e5e4c7ea5

Huliiiiii avatar Mar 18 '25 17:03 Huliiiiii

Hi there! πŸ‘‹ We're working to clean up our issue tracker by closing older issues that might not be relevant anymore. If you are able to reproduce this issue in the latest version of Zed, please let us know by commenting on this issue, and we will keep it open. If you can't reproduce it, feel free to close the issue yourself. Otherwise, we'll close it in 7 days. Thanks for your help!

github-actions[bot] avatar Jul 23 '25 07:07 github-actions[bot]

Don't close it bot

JunkuiZhang avatar Jul 23 '25 07:07 JunkuiZhang

Well if it's on Blade, why should not we close it?

SomeoneToIgnore avatar Jul 23 '25 09:07 SomeoneToIgnore

Well, we can close this, but anyway, we will finally fix this when the dix11 branch is merged

JunkuiZhang avatar Jul 23 '25 14:07 JunkuiZhang