zed icon indicating copy to clipboard operation
zed copied to clipboard

The info overlay doesn't disappear automatically

Open Abhinav5383 opened this issue 1 year ago • 4 comments

Check for existing issues

  • [x] Completed

Describe the bug / provide steps to reproduce it

The info overlay that shows up when the cursor enters a function parentheses doesn't disappear after exiting that context. The overlay keeps showing as long as the cursor is inside the function, and if mouse clicked into another function, it starts showing the info of that function

*typescript with default lsp

Environment

Zed: v0.146.4 (Zed) OS: Linux Wayland arch unknown Memory: 7.5 GiB Architecture: x86_64 GPU: Intel(R) UHD Graphics (TGL GT2) || Intel open-source Mesa driver || Mesa 24.1.4-arch1.2

If applicable, add mockups / screenshots to help explain present your vision of the feature

Screenshot:

image

Screen recording:

https://github.com/user-attachments/assets/4d99aa9b-799e-413f-877f-881802fdac58

If applicable, attach your Zed.log file to this issue.

Zed.log

Abhinav5383 avatar Aug 02 '24 04:08 Abhinav5383

A little thing i noticed, this thing doesn't happen in javascript files, only in typescript files I thought it was because typescript had type definitions for the parameters or something, but it doesn't happen in go also

Abhinav5383 avatar Aug 08 '24 03:08 Abhinav5383

This is happening to me too. I'm mainly working in tsx files at the moment. Basically, every time I autocomplete a prop on a component by hitting enter the info overlay shows, then when ever I move the cursor the overlay is still visible but updates based on its nearest component.

craigwduckett avatar Aug 21 '24 01:08 craigwduckett

That functionality could be disabled with

"show_signature_help_after_edits": true,

set to false, there's still an editor: show signature help (cmd-i on mac by default) to trigger this manually, and esc to hide any of the pop-ups related.

SomeoneToIgnore avatar Aug 21 '24 08:08 SomeoneToIgnore

That functionality could be disabled with

"show_signature_help_after_edits": true,

set to false, there's still an editor: show signature help (cmd-i on mac by default) to trigger this manually, and esc to hide any of the pop-ups related.

The thing is, that popup should only appear

  • after typing something inside a parameter parentheses
  • after typing the parentheses itself and should automatically disappear when out of those parentheses

but it needs me to click esc each time to dismiss it, it's annoying to reach out to that key on the corner each time

Abhinav5383 avatar Aug 23 '24 03:08 Abhinav5383

Hi there! 👋 We're working to clean up our issue tracker by closing older issues that might not be relevant anymore. If you are able to reproduce this issue in the latest version of Zed, please let us know by commenting on this issue, and we will keep it open. If you can't reproduce it, feel free to close the issue yourself. Otherwise, we'll close it in 7 days. Thanks for your help!

github-actions[bot] avatar Mar 11 '25 11:03 github-actions[bot]

that popup now doesn't even appear in the first place, so should I consider that as the issue being fixed ?

Abhinav5383 avatar Mar 11 '25 13:03 Abhinav5383

I believe so: now https://github.com/zed-industries/zed/issues/15667#issuecomment-2301479678 is applied as a default. Thank you for the feedback.

SomeoneToIgnore avatar Mar 11 '25 13:03 SomeoneToIgnore