zed icon indicating copy to clipboard operation
zed copied to clipboard

Add icon to the tabbar title

Open fazibear opened this issue 1 year ago • 4 comments

There is a nice icon in terminal tab, but editor tab are without icons. Here is a PR to add them.

Just one question: A margin between an icon and text is a space character at the beginning of the label. Is this done on purpose?

Beautiful codebase BTW ;)

Release Notes:

  • Added tabbar title icon
Screenshot 2024-07-13 at 17 08 56

fazibear avatar Jul 13 '24 14:07 fazibear

We require contributors to sign our Contributor License Agreement, and we don't have @fazibear on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

cla-bot[bot] avatar Jul 13 '24 14:07 cla-bot[bot]

@cla-bot check

fazibear avatar Jul 13 '24 14:07 fazibear

The cla-bot has been summoned, and re-checked this pull request!

cla-bot[bot] avatar Jul 13 '24 14:07 cla-bot[bot]

This closed PR seems more complete, https://github.com/zed-industries/zed/pull/12443

MatinAniss avatar Jul 14 '24 08:07 MatinAniss

Thanks for opening this PR, but I'm going to close this in favor of https://github.com/zed-industries/zed/pull/14523.

maxdeviant avatar Jul 15 '24 22:07 maxdeviant