`experimental.theme_overrides` should have an optional separation between light mode and dark mode.

[didier]

Check for existing issues

• [X] Completed

Describe the feature

I've set up some customisations of a theme which I'm quite happy with, but I'd also like to customise its light mode variant. Currently, I don't believe there is a way to do this on a per-theme or per-mode basis.

Would love it if this was possible!

If applicable, add mockups / screenshots to help present your vision of the feature

"experimental.theme_overrides": {
  "dark": {
    // ... dark mode options
  },
  "light": {
    // ... light mode options
  },
  // ... shared / global overrides
 }

[ddbrierton]

In VS Code's settings.json the theme overrides are specific to each theme:

  "workbench.colorCustomizations": {
    "[Name of theme]": {
      // overrides go here, e.g.
      "editorBracketHighlight.foreground1": "#FFE6B3",
    },
  }

I believe that Zed should do the same, which would also solve the above issue.

Currently I'm switching between two themes (both dark themes) depending on how bright the ambient light is, but I have different overrides for each, and so I have to open setting and comment out one block and uncomment another whenever I switch themes.