zed icon indicating copy to clipboard operation
zed copied to clipboard

Autocompletions show no import paths, as they did before

Open stjepangolemac opened this issue 1 year ago • 6 comments

Check for existing issues

  • [X] Completed

Describe the bug / provide steps to reproduce it

image

As shown here for Rust, the only import path shown is for the local crate in the workspace.

Environment

Zed: v0.142.5 (Zed) OS: macOS 14.5.0 Memory: 64 GiB Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

There are numerous issues that mention this but after a quick glance to me it looks like most are dismissed as "missing features" and closed in favor of other issues, but that is wrong. The import paths were displayed before, and they're not anymore, this is a regression.

  • https://github.com/zed-industries/zed/issues/10204
  • https://github.com/zed-industries/zed/issues/4457
  • https://github.com/zed-industries/zed/issues/10075
  • https://github.com/zed-industries/zed/issues/7099
  • https://github.com/zed-industries/zed/issues/4457

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

Zed.log

stjepangolemac avatar Jul 05 '24 08:07 stjepangolemac

Hey, thanks for the report. This has already been fixed in https://github.com/zed-industries/zed/pull/13797 and should be out on Stable in 2 weeks IIRC.

osiewicz avatar Jul 06 '24 18:07 osiewicz

Awesome thank you @osiewicz!

stjepangolemac avatar Jul 08 '24 09:07 stjepangolemac

@osiewicz when is this hitting preview? It still doesn't work for me.

stjepangolemac avatar Jul 12 '24 06:07 stjepangolemac

It should already be on Preview. Can you share a minimal reproduction case where you'd expect to see import path in completions, but it's not there?

osiewicz avatar Jul 12 '24 06:07 osiewicz

image

This is latest preview version. I don't know how this works but looks like functions don't show import paths while structs do?

stjepangolemac avatar Jul 12 '24 14:07 stjepangolemac

Issue is still occurring on version 59ce353

road2react avatar Jul 14 '24 03:07 road2react

I landed another round of improvements in https://github.com/zed-industries/zed/pull/14490

osiewicz avatar Jul 15 '24 12:07 osiewicz

I'm running 144.3 now and still can't see import paths. Maybe it's still not on preview?

image

stjepangolemac avatar Jul 17 '24 07:07 stjepangolemac

@stjepangolemac new Preview builds are released on Wednesday so yeah, it'll be on Preview today (in 8 hours or so)

osiewicz avatar Jul 17 '24 08:07 osiewicz

Just checked and it works now. Thank you!

stjepangolemac avatar Jul 18 '24 13:07 stjepangolemac