Support terminals with ssh in remote projects
Release Notes:
- Added a way to create terminal tabs in remote projects, if an ssh connection string is specified
Squawk Report
✅ 0 violations across 1 file(s)
crates/collab/migrations/20240514164510_store_ssh_connect_string.sql
ALTER TABLE dev_servers ADD COLUMN ssh_connection_string TEXT;
✅ Rule Violations (0)
No violations found.
⚡️ Powered by Squawk (0.26.0), a linter for PostgreSQL, focused on migrations
nice!
A few bugs:
- If the project directory starts with
~you get a "no such file or directory" - The terminal icon should show up for these projects (it's currently hidden for all remote projects)
If the project directory starts with ~ you get a "no such file or directory"
Fixed that by escaping the paths manually: turns out all rust bash escaping crates just wrap the line with whitespaces into single quotes, but we're in the bash argument context, where quotes will be escaped, spoiling the argument.
Had to manually cover all non-~ cases: this means there is a chance some ~/very/~~odd_path might break but I think it's fine.
The terminal icon should show up for these projects (it's currently hidden for all remote projects)
That seems to be ok and present, as discussed.