zed icon indicating copy to clipboard operation
zed copied to clipboard

Support terminals with ssh in remote projects

Open SomeoneToIgnore opened this issue 1 year ago • 2 comments

Release Notes:

  • Added a way to create terminal tabs in remote projects, if an ssh connection string is specified

SomeoneToIgnore avatar May 16 '24 13:05 SomeoneToIgnore

Squawk Report

✅ 0 violations across 1 file(s)


crates/collab/migrations/20240514164510_store_ssh_connect_string.sql

ALTER TABLE dev_servers ADD COLUMN ssh_connection_string TEXT;

✅ Rule Violations (0)

No violations found.


📚 More info on rules

⚡️ Powered by Squawk (0.26.0), a linter for PostgreSQL, focused on migrations

github-actions[bot] avatar May 16 '24 13:05 github-actions[bot]

nice!

A few bugs:

  • If the project directory starts with ~ you get a "no such file or directory"
  • The terminal icon should show up for these projects (it's currently hidden for all remote projects)

ConradIrwin avatar May 16 '24 17:05 ConradIrwin

If the project directory starts with ~ you get a "no such file or directory"

Fixed that by escaping the paths manually: turns out all rust bash escaping crates just wrap the line with whitespaces into single quotes, but we're in the bash argument context, where quotes will be escaped, spoiling the argument. Had to manually cover all non-~ cases: this means there is a chance some ~/very/~~odd_path might break but I think it's fine.

The terminal icon should show up for these projects (it's currently hidden for all remote projects)

That seems to be ok and present, as discussed.

SomeoneToIgnore avatar May 17 '24 11:05 SomeoneToIgnore