Terminal button sometimes multiplies when saving settings file with errors

[jansol]

Check for existing issues

• [X] Completed

Describe the bug / provide steps to reproduce it

• Open a terminal pane, launch something long-running but not very chatty (cargo watch or the like)
• Add some invalid noise to settings.json hit save
• Observe terminal button proliferation in status bar

Noticed this while faffing about trying to get Typst and Vale language servers to run together. Can't seem to reproduce this consistently, unfortunately.

Environment

Zed: v1.0.0 (Zed Dev 4301d065ff61e1cae607dfeb3d52fab6caff355e) OS: Linux 1.0.0 Memory: 125.7 GiB Architecture: x86_64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

No response

[bennetbo]

Sounds like #9688 to me (although it's another button)?

[jansol]

Yeah, seems very similar. Happened with a fresh git build from today, though (exact commit hash is probably not useful since it's the text_input_v3 PR applied on top of main)

[CharlesChen0823]

I might known what problems.