zed icon indicating copy to clipboard operation
zed copied to clipboard

Add "New Window" entry to Dock icon

Open bkircher opened this issue 1 year ago • 3 comments

Check for existing issues

  • [X] Completed

Describe the feature

The Zed Dock icon is missing a "New Window" entry. It's just a minor thing but, yeah, I missed it since VS Code brings one.

If applicable, add mockups / screenshots to help present your vision of the feature

Zed: Screenshot 2024-05-10 at 09 59 46 VS Code: Screenshot 2024-05-10 at 09 59 27

bkircher avatar May 10 '24 08:05 bkircher

Does anyone know where this menu is actually configured in zed I've spent over three hours looking, and GPUI has no docks on the app level Menus just the menubar menus, I can't find where in platform.rs this would even be setup as NSDocktile is never even imported from cocoa??

This should require setting a normal NSMenu for the NSDocktile but there doesn't seem to be any point where a menu is assigned to the docktile.

I think the platform trait is missing a section for app menus, as in app icon, separate from the Menu bar.

@ConradIrwin Could you help me figure this out, I'm not sure who else might know?

versecafe avatar May 14 '24 06:05 versecafe

It doesn't look like we have configured that menu yet (it seems like the default one). So we may need to build some of the infrastructure here.

If you want to pair on this, feel free to book time here: https://calendly.com/conradirwin/pairing

ConradIrwin avatar May 14 '24 18:05 ConradIrwin

Not sure if this is helpful but #8952 added entries for recent projects, relevant code is here

bennetbo avatar May 14 '24 19:05 bennetbo

@ConradIrwin Are you still free for this afternoon?

versecafe avatar May 20 '24 16:05 versecafe