zed icon indicating copy to clipboard operation
zed copied to clipboard

Expanded diff hunks cover an extra line

Open eth0net opened this issue 9 months ago • 1 comments

Check for existing issues

  • [X] Completed

Describe the bug / provide steps to reproduce it

Git diff indicators next to the line numbers show which lines have been changed as expected, but when expanding the hunk to view the diff the add portions claim the next line even though it's unchanged.

Environment

Zed: v0.135.0 (Zed Preview) OS: macOS 14.5.0 Memory: 64 GiB Architecture: x86_64

If applicable, add mockups / screenshots to help explain present your vision of the feature

Closed diff hunks showing the changed lines

Screenshot 2024-05-08 at 21 26 07

Open diff hunks claiming the extra lines

Screenshot 2024-05-08 at 21 26 28

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

No response

eth0net avatar May 08 '24 20:05 eth0net

Note: I will try to resolve this myself but I am also working on #11504 right now 👀

eth0net avatar May 08 '24 20:05 eth0net

cc: @SomeoneToIgnore

JosephTLyons avatar May 09 '24 18:05 JosephTLyons

Thank you, https://github.com/zed-industries/zed/pull/11632 is supposed to fix that.

SomeoneToIgnore avatar May 09 '24 22:05 SomeoneToIgnore