Profile favicons on inline git blame don't show up

[dimeeentor]

Check for existing issues

• [x] Completed

Describe the bug / provide steps to reproduce it

1. Toggle on "Inline Git blame"
2. Hover over inline hint until the popup appears

Environment

Zed: v0.134.1 (Zed Preview) OS: macOS 14.4.1 Memory: 16 GiB Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

When I was using stable version and when this feature was introduced it worked fine, then I've switched to the preview one and it doesn't work no more.

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

No response

[Moshyfawn]

I can't seem to reproduce the problem on the same version as you. Are there any related logs generated that you can find by selecting zed: open log in the command palette after trying to view the popovver with the unloaded git avatar?

[dimeeentor]

Seems like nothing related to unloaded git avatars, however when I toggle on and off inline git blame and git blame, then null can appear in the logs.

Edit: When I hover over inline git blame to get the popup – nothing get added into the logs.

2024-05-08T09:04:01+02:00 [INFO] Initializing default prettier with plugins {}
2024-05-08T09:04:01+02:00 [INFO] starting language servers for CSS: vscode-css-language-server, tailwindcss-language-server
2024-05-08T09:04:01+02:00 [INFO] Language server with id 1 sent unhandled notification workspace/diagnostic/refresh:
null
2024-05-08T09:05:31+02:00 [ERROR] failed to canonicalize root path: No such file or directory (os error 2)
2024-05-08T09:05:32+02:00 [ERROR] failed to canonicalize root path: No such file or directory (os error 2)
2024-05-08T09:05:33+02:00 [ERROR] unexpected item event after pane was dropped
2024-05-08T09:05:33+02:00 [ERROR] failed to canonicalize root path: No such file or directory (os error 2)
2024-05-08T09:05:33+02:00 [ERROR] failed to canonicalize root path: No such file or directory (os error 2)
2024-05-08T09:05:41+02:00 [ERROR] failed to canonicalize root path: No such file or directory (os error 2)
2024-05-08T09:05:41+02:00 [ERROR] failed to canonicalize root path: No such file or directory (os error 2)
2024-05-08T09:05:53+02:00 [INFO] Initializing default prettier with plugins {}
2024-05-08T09:05:53+02:00 [INFO] starting language servers for CSS: vscode-css-language-server, tailwindcss-language-server
2024-05-08T09:05:53+02:00 [INFO] Initializing default prettier with plugins {}
2024-05-08T09:05:53+02:00 [INFO] starting language servers for CSS: vscode-css-language-server, tailwindcss-language-server
2024-05-08T09:05:53+02:00 [INFO] Language server with id 1 sent unhandled notification workspace/diagnostic/refresh:
null

[maxdeviant]

@dimeeentor Are you seeing this in a public or private repo?

[dimeeentor]

A private one. I guess an important thing, is that it worked when I was using Zed stable.

[mrnugget]

We can't fetch commit information from private repositories without authentication. GitHub's API doesn't allow us to fetch the commit author without having access to the repository.

We need to talk to the GitHub API because just by pure git information, we can't get the avatar of the author associated with the commit. (We'd need to use something like gravatar for that, not sure if they're still around)

But I did put an escape hatch in: if you launch Zed from the CLI and GITHUB_TOKEN is set, then that's used to talk to GitHub. So it's possible that this is what was happening when using Zed stable.

I'm going to close this, because right now it's not supported to get the avatar from a private repository. Happy to reopen if my assessment here is wrong.