zed icon indicating copy to clipboard operation
zed copied to clipboard

windows: Better dispatcher

Open JunkuiZhang opened this issue 9 months ago • 2 comments

This PR leverages a more modern Windows API to implement WindowsDispatcher, aligning its implementation more closely with that of the macOS platform. The following improvements have been made:

  1. Similar to macOS, there is no longer a need to use sender and receiver to dispatch a Runnable on the main thread.
  2. There is also no longer a need to use an Event for synchronization.
  3. Consistent with #7506 and #11269, Runnable is now executed with high priority.

However, this PR raises the minimum Windows version requirement of GPUI to Windows 10, specifically Windows 10 Fall Creators Update (10.0.16299). However, the alacritty_terminal dependency in Zed relies on conPTY on Windows, an API introduced in the Windows 10 Fall Creators Update. Therefore, the impact of this PR on Zed should be minimal. I'd like to hear your voices about this PR, especially about the minimum Windows version bumping.

Release Notes:

  • N/A

JunkuiZhang avatar May 07 '24 10:05 JunkuiZhang

Just chiming in: our minimum supported Windows version is Windows 10 anyways since we started using Rust 1.78: https://releases.rs/docs/1.78.0/ Plus, fall creators update has been released 7 years ago. Our minimal supported macOS version was released 2 years after that, in 2019. I think we're fine with the bump.

osiewicz avatar May 07 '24 10:05 osiewicz

Just chiming in: our minimum supported Windows version is Windows 10 anyways since we started using Rust 1.78: https://releases.rs/docs/1.78.0/ Plus, fall creators update has been released 7 years ago. Our minimal supported macOS version was released 2 years after that, in 2019. I think we're fine with the bump.

That's good news, thank you!

JunkuiZhang avatar May 07 '24 13:05 JunkuiZhang

Thank you!

mikayla-maki avatar May 09 '24 21:05 mikayla-maki