zed icon indicating copy to clipboard operation
zed copied to clipboard

Find all navigate to line

Open nixpulvis opened this issue 9 months ago • 1 comments

Check for existing issues

  • [X] Completed

Describe the feature

After using the find all function to search for matches and returning multiple matches within the same file, I would like to navigate to other matches by clicking on them. Unless I'm missing something, currently only the first match is opened when you click on the file name.

Sorry if this was already mentioned, I tried to search the issues. Or if I'm just missing the functionality.

If applicable, add mockups / screenshots to help present your vision of the feature

No response

nixpulvis avatar May 04 '24 20:05 nixpulvis

If I understand your request correctly, you're looking for that thin line that you can press to go to the next definition on that particular line. Let me know if that's what you're looking for.

image

Moshyfawn avatar May 05 '24 16:05 Moshyfawn

Indeed that is the functionality I was looking for!

Just my two cents, but perhaps a small redesign of this interface could benefit users.

A. Allow collapsing of the top filename match (useful for searches with a lot of matched files) B. Jump to match when clicking (double clicking?) on the match itself

I appreciate being able to treat the match buffer more or less like a normal buffer, but given that the matched text is already specially formatted, it makes sense to me to also give it a special action.

I also noticed, if I click on the "Expand Excerpt" button it will show duplicate lines if the matches are near each other. This could be optimized to simply remove the line between the matches.

nixpulvis avatar May 06 '24 13:05 nixpulvis

Adding this to the papercuts project, as we've found that a lot of users don't know they can jump from mullt-buffer to buffer.

JosephTLyons avatar May 06 '24 15:05 JosephTLyons

I'm happy to test or give feedback as a new user here. I'm loving Zed and using it more and more now.

nixpulvis avatar May 06 '24 15:05 nixpulvis

Really appreciate the feedback here, but I'm going to close this out for:

  • https://github.com/zed-industries/zed/issues/9718

I have it on our papercuts project as well. If you think its missing any details, feel free to add it as a comment, and make sure to upvote with 👍.

JosephTLyons avatar May 20 '24 03:05 JosephTLyons