zed icon indicating copy to clipboard operation
zed copied to clipboard

Toggling the hunk diff has caused a panic

Open Moshyfawn opened this issue 1 year ago • 1 comments

Check for existing issues

  • [X] Completed

Describe the bug / provide steps to reproduce it

I can't reproduce it anymore, but my whole routine was:

  1. Open Zed (I was already logged into my profile, but I got the "Log in" button next to my avatar. Clicking it did nothing; restarting the editor fixed it, and also allowed the editor to detect an update).
  2. Updated Zed by clicking on the "Restart to update" message.
  3. Opened a docker file in the already opened project and installed the docker extension from the suggestion.
  4. Copied the updated Dockerfile text into the editor and save the changes.
  5. Selected all 28 lines of the file and fired `editor: toggle hunk diff'.
  6. Zed crashed.

Environment

Zed: v0.135.0 (Zed Nightly 5ce45908b190b8f55e079775d881e432fe0d77a5) OS: macOS 14.4.1 Memory: 18 GiB Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

[ERROR] unexpected item event after pane was dropped
[ERROR] {
  "thread": "main",
  "payload": "offset 1968 is out of range, max allowed is 1920",
  "location_data": {
    "file": "crates/text/src/text.rs",
    "line": 2593
  },
  "backtrace": [
    "<backtrace::symbolize::gimli::Context>::new",
    "<backtrace::symbolize::gimli::Context>::new",
    "Zed::reliability::init",
    "std::sys_common::thread_info::current_thread",
    "std::sys_common::process::CommandEnv::set",
    "std::process::Child::wait_with_output",
    "std::sys_common::backtrace::_print_fmt::{{closure}}::{{closure}}",
    "<cranelift_entity::map::SecondaryMap<cranelift_codegen::ir::entities::Block, core::ops::range::Range<usize>>>::resize_for_index_mut",
    "editor::element::register_action::<editor::actions::CopyHighlightJson, <editor::Editor>::copy_highlight_json>::{closure#0}",
    "editor::element::register_action::<editor::actions::ToggleComments, <editor::Editor>::toggle_comments>::{closure#0}",
    "editor::element::register_action::<editor::actions::ExpandExcerpts, <editor::Editor>::expand_excerpts>::{closure#0}",
    "editor::element::register_action::<editor::actions::NewlineAbove, <editor::Editor>::newline_above>::{closure#0}",
    "<editor::element::register_action<editor::actions::Format, <editor::element::EditorElement>::register_actions::{closure#16}>::{closure#0} as core::ops::function::FnOnce<(&dyn core::any::Any, gpui::window::DispatchPhase, &mut gpui::window::WindowContext)>>::call_once::{shim:vtable#0}",
    "<gpui::elements::list::ListState>::splice",
    "<gpui::app::entity_map::EntityMap>::insert::<copilot_ui::copilot_completion_provider::CopilotCompletionProvider>",
    "core::ptr::drop_in_place::<core::option::Option<rpc::proto::envelope::Payload>>",
    "<<theme::schema::ThemeColorsContent as serde::de::Deserialize>::deserialize::__Visitor as serde::de::Visitor>::visit_map::<serde::__private::de::FlatStructAccess<serde_json_lenient::error::Error>>",
    "<gpui::window::WindowContext as gpui::VisualContext>::update_view::<workspace::Workspace, (), Zed::zed::initialize_workspace::{closure#0}::{closure#9}::{closure#0}::{closure#0}>",
    "addr2line::function::Function<R>::parse_children",
    "core::ptr::drop_in_place::<project::task_inventory::SourceInInventory>"
  ],
  "app_version": "0.135.0",
  "release_channel": "Zed Nightly",
  "os_name": "macOS",
  "os_version": "14.4.1",
  "architecture": "aarch64",
  "panicked_on": 1714745328128,
  "installation_id": "9a6f0846-72ca-4f1d-b9e3-251a56f5c267",
  "session_id": "7b162e62-a7b0-4e8b-b6f5-678696236cd7"
}

Moshyfawn avatar May 03 '24 14:05 Moshyfawn

cc @SomeoneToIgnore

JosephTLyons avatar May 03 '24 18:05 JosephTLyons

I believe https://github.com/zed-industries/zed/pull/11656 had fixed this panic as I could not spot it in the reports anymore. Closing this for now.

SomeoneToIgnore avatar May 22 '24 08:05 SomeoneToIgnore