Wrong primary language_server for formatting

[luckydye]

Check for existing issues

• [X] Completed

Describe the bug / provide steps to reproduce it

When trying to run formatting via lsp, it does not use the right language server.

I tried to to prioritise them with the "language_servers" settings like this:

"language_servers": [
    "biome",
    "typescript-language-server",
    "!eslint"
],

But I noticed it will still only use "typescript-language-server" to format the buffer.

Printing the language_server.name() to logs: Should be "biome_lsp".

Environment

Zed: v0.135.0 (Zed Dev d8ca15372c5dccb4f49b6ae13014059f9594dc03) OS: macOS 14.2.1 Memory: 16 GiB Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

No response

[maxdeviant]

@luckydye What do you have your "formatter setting set to? Is it "formatter": "language_server"?

[luckydye]

@maxdeviant Yes, these are my exact settings:

{
  "formatter": "language_server",
  "language_servers": [
    "biome",
    "typescript-language-server",
    "!eslint",
    "..."
  ]
}

[luckydye]

Maybe it would make sense to have a setting like this?

{
  "formatter": {
    "language_server": "biome"
  }
}

[unitythemaker]

This works for me, doesn't it work on you?

  "formatter": {
    "code_actions": {
      "source.fixAll.eslint": true
    }
  },

[luckydye]

@unitythemaker source.fixAll fixes linting errors in most cases. This may work for for eslint, but its not a universal solution. Mainly because eslint sees formatting errors as lint errors, but biome for example, follows a different philosophy.

[osiewicz]

@luckydye I've just landed a PR which - amongst other things - adds name argument to the `language_server formatter:

"formatter": {"language_server": {"name": "YOUR_LSP_NAME"}}

[luckydye]

@osiewicz ohh perfect! Thanks!