zed icon indicating copy to clipboard operation
zed copied to clipboard

noisy network calls to collab.zed.dev even when disabling chat and collaboration panels

Open tecandrew opened this issue 9 months ago • 3 comments

Check for existing issues

  • [X] Completed

Describe the bug / provide steps to reproduce it

I monitor my network DNS calls and traffic, and the the last 24 hours collab.zed.dev has been called hundreds of times even when I have my settings to disable chat and collaboration stuff as off. I figured these settings would also disable network calls to collab stuff?

image

  "chat_panel": {
    "button": false
  },
  "collaboration_panel": {
    "button": false
  },

Other Observations

I eventually blocked that domain entirely, and as a result the top right "GitHub" icon shows that I'm not logged in anymore and makes me think that the git blame stuff doesn't work, but it does 😃 so it's a bit confusing

Screenshot 2024-04-30 at 1 06 22 PM

Environment

Zed: v0.132.5 (Zed) OS: macOS 14.4.1 Memory: 16 GiB Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

No response

tecandrew avatar Apr 30 '24 20:04 tecandrew

Do you have telemetry enabled? That will also hit collab.zed.dev with usage data, panics and crashes.

ConradIrwin avatar May 01 '24 04:05 ConradIrwin

no, I don't have telemetry enabled 😅

  "telemetry": {
    "diagnostics": false,
    "metrics": false
  }

is what I have set in my settings.json

tecandrew avatar May 01 '24 14:05 tecandrew

Hmm! I wonder if we just spend energy keeping an idle unused connection open for you in case you change your mind...

I've noticed that we see more reconnects on our server than I'd expect, so it seems plausible that we establish a web-socket connection, wait for it to idle timeout, and then re-establish it, over and over again.

Seems worth fixing!

ConradIrwin avatar May 01 '24 16:05 ConradIrwin

Any updates on this issue? My employer blocked the zed.dev domain because of data governance issues with the collaboration tools that zed provide. I convinced them to only block collab.zed.dev but they will certainly not like if my device continuously tries to connect to blocked domains.

For now I will add an entry to /etc/hosts to make sure those requests do not leave my laptop.

If you want help with this I am happy to look into it?

nilskch avatar Jun 06 '24 14:06 nilskch

@nilskch I haven't looked into it yet. If you're willing to, it would be good to try and figure out why this is happening. There may be something in your zed logs, or if you have a tool that can intercept network requests we can see a little more about what's going on

ConradIrwin avatar Jun 06 '24 18:06 ConradIrwin