zed icon indicating copy to clipboard operation
zed copied to clipboard

Add Windows specific path parsing

Open TiltedToast opened this issue 9 months ago • 3 comments

Since Windows paths are known to be weird and currently not handled at all (outside of relative paths that just happen to work), I figured I would add a windows specific implementation for parsing absolute paths. It should be functionally the same, of course there's always a chance I missed an edge case though.

This should fix

  • #10849

Note that there are still some cases that will probably break the current implementation, namely local drives that do not have a drive letter assigned (not sure how to handle those). There's also UNC paths but I don't know how important those are at the moment (I'll allow myself to assume not at all)

Release Notes:

  • N/A

TiltedToast avatar Apr 28 '24 08:04 TiltedToast

We require contributors to sign our Contributor License Agreement, and we don't have @TiltedToast on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

cla-bot[bot] avatar Apr 28 '24 08:04 cla-bot[bot]

@cla-bot check

TiltedToast avatar Apr 28 '24 08:04 TiltedToast

The cla-bot has been summoned, and re-checked this pull request!

cla-bot[bot] avatar Apr 28 '24 08:04 cla-bot[bot]

A related PR #11083 , it seems that we need the zed team to decide how to handle the UNC path.

JunkuiZhang avatar Apr 29 '24 10:04 JunkuiZhang

Yeah, there's not much of a point in supporting them if you're never going to allow people to edit on remote servers that way I guess.

Not sure how feasible that would be anyway, may as well just do it via ssh or something.

TiltedToast avatar Apr 30 '24 06:04 TiltedToast