zed icon indicating copy to clipboard operation
zed copied to clipboard

Windows: Fix canonicalize return UNC path

Open CharlesChen0823 opened this issue 1 year ago • 1 comments

In Windows platform, using notify to watch file events.

  1. in notify windows implement, we get the full file path, just with path.join(file_path).
  2. In zed worktree start_backgroud_scan_tasks, abs_path is not unc path, so we get all file events with not unc path.
  3. but in zed worktree process_event, we strip_prefix unc path all times, it will always print annoy error.

@mikayla-maki I can't reopen pre closed pr #10501 .

Release Notes:

  • N/A

CharlesChen0823 avatar Apr 27 '24 02:04 CharlesChen0823

gpui::platform::windows::prompt_for_paths return not unc path, but i don't think here return unc path is better choice.

CharlesChen0823 avatar Apr 28 '24 11:04 CharlesChen0823

@CharlesChen0823 is this PR ready to go? The current fix looks a lot better and I'd be down to merge it :)

mikayla-maki avatar May 06 '24 20:05 mikayla-maki

@mikayla-maki yes, it's ready for review.

CharlesChen0823 avatar May 07 '24 00:05 CharlesChen0823

thank you!

mikayla-maki avatar May 07 '24 01:05 mikayla-maki