zed
zed copied to clipboard
Windows: Fix canonicalize return UNC path
In Windows platform, using notify to watch file events.
- in notify windows implement, we get the full file path, just with
path.join(file_path). - In zed worktree start_backgroud_scan_tasks,
abs_pathis not unc path, so we get all file events with not unc path. - but in zed worktree process_event, we
strip_prefixunc path all times, it will always print annoy error.
@mikayla-maki I can't reopen pre closed pr #10501 .
Release Notes:
- N/A
gpui::platform::windows::prompt_for_paths return not unc path, but i don't think here return unc path is better choice.
@CharlesChen0823 is this PR ready to go? The current fix looks a lot better and I'd be down to merge it :)
@mikayla-maki yes, it's ready for review.
thank you!