zed icon indicating copy to clipboard operation
zed copied to clipboard

Sync maximized state from top-level configure event for a wayland window

Open aki237 opened this issue 1 year ago • 4 comments

  • Otherwise is_maximized always returns true

Release Notes:

  • Fixed maximized state. Tested with a dummy maximize/restore button with the zoom() (not implemented yet). Without the right maximized, in toggle zoom function is not possible to call set_maximized() or unset_maximized().
    fn zoom(&self) {
      if self.is_maximized() {
        self.borrow_mut().toplevel.unset_maximized();
      } else {
        self.borrow_mut().toplevel.set_maximized();
      }
    }

aki237 avatar Apr 25 '24 18:04 aki237

We require contributors to sign our Contributor License Agreement, and we don't have @aki237 on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

cla-bot[bot] avatar Apr 25 '24 18:04 cla-bot[bot]

@cla-bot check

aki237 avatar Apr 25 '24 18:04 aki237

The cla-bot has been summoned, and re-checked this pull request!

cla-bot[bot] avatar Apr 25 '24 18:04 cla-bot[bot]

Sorry for the commits, I was working on a PoC for draggable wayland windows, accidently pushed it to this branch.

aki237 avatar Apr 25 '24 22:04 aki237

Thank you!

mikayla-maki avatar Apr 26 '24 21:04 mikayla-maki