zed
zed copied to clipboard
Fix project-panel double click file support on Windows
Release Notes:
- Fixed project panel double click to force open file on Windows.
Ref issue: #10898
@bennetbo
I saw you was also used event.down.click_count
in Markdown Preview.
https://github.com/zed-industries/zed/commit/7dccbd8e3b61c48ae174807a4023332b7c1df06a#diff-c8d1735cb347ea08d03198df112343ec50a74de8d50414a6f3be6c6d674c6d19R161
And this also used in other place:
Test demo after updated
Looks like it is no side effect
I have take a look for the mouse click implementation on Windows.
It is looks like we forgot to change MouseUp click_count in PR #9642. In that PR changes, I just saw only have MouseDown?
https://github.com/zed-industries/zed/blob/53f67a82414fa0429fe8f8bdc2098700f65aa4b6/crates/gpui/src/platform/windows/window.rs#L709
That sounds like the problem then!
@mikayla-maki You can review again now.
https://github.com/zed-industries/zed/assets/5518/cd6f4578-807b-4791-98c5-bc30175eeeb3
Perfect!