zed icon indicating copy to clipboard operation
zed copied to clipboard

Improve Close Dialog Keyboard Accessibility (Again)

Open boredstiff opened this issue 1 year ago • 1 comments

Describe the bug / provide steps to reproduce it

Check for existing issues:

  • [x] Done, but it was closed as fixed a year ago, when the dialog looks like it was a different one than it is now. https://github.com/zed-industries/zed/issues/5990

Describe the bug: image

This dialog does not highlight a button, so I can't tab through it to select other options. I'm tabbing through, pressing up and down, and none of the buttons are highlighted.

It would be nice if the dialog functionality was fixed to how it previously worked, where the top option is selected so we can tab through it and not have to reach for the mouse to close a file.

As the original issue mentioned, the following keypresses would be nice in this dialog to be one keypress away from the action.

  • Cancel: Escape
  • Don't Save: Space
  • Save: Enter

Thank you :)

Environment

MacOS 14.1.1

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

No response

boredstiff avatar Apr 23 '24 04:04 boredstiff

Current Zed on mac spawns system dialogues that do exactly what is requested:

image

But I have the keyboard navigation enabled in the system settings: image

If I turn that off and restart Zed, I get back to the sorry state from the screenshots, but when I turn it back, it works again. Do you have this setting on and things still are not working for you?

SomeoneToIgnore avatar Apr 23 '24 05:04 SomeoneToIgnore

That worked, thank you very much. I had no idea this setting existed.

boredstiff avatar Apr 23 '24 20:04 boredstiff