zed icon indicating copy to clipboard operation
zed copied to clipboard

Enable random_channel_buffer_tests to run on Linux

Open kain88-de opened this issue 1 year ago • 2 comments

With this patch applied I can see the following line in the test output:

test tests::random_channel_buffer_tests::test_random_channel_buffers has been running for over 60 seconds

Without it I run in a failure with 'Invalid keystroke cmk-,

Release Notes:

  • Fixed random_channel_buffer_tests on Linux

kain88-de avatar Apr 22 '24 20:04 kain88-de

We require contributors to sign our Contributor License Agreement, and we don't have @testmaxli on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

cla-bot[bot] avatar Apr 22 '24 20:04 cla-bot[bot]

When do you plan to run the unit tests on linux?

kain88-de avatar Apr 22 '24 20:04 kain88-de

When do you plan to run the unit tests on linux?

Probably as we get closer to a full Linux release.

I'm not sure what the current state of the tests is.

maxdeviant avatar Apr 29 '24 14:04 maxdeviant

Currently 38 tests fail with this patch applied. I assume most of those are similar issues. I can work a bit on fixing them. I would feel better about that if the CI runs the tests to ensure they are not broken again in the future. Ideally all new test would also pass on Linux.

However, do you want this at the moment?

kain88-de avatar May 01 '24 19:05 kain88-de

Currently 38 tests fail with this patch applied. I assume most of those are similar issues. I can work a bit on fixing them. I would feel better about that if the CI runs the tests to ensure they are not broken again in the future. Ideally all new test would also pass on Linux.

However, do you want this at the moment?

I'm not sure that we're ready to enable Linux tests in CI quite yet.

maxdeviant avatar May 01 '24 19:05 maxdeviant