Improve completions for TypeScript

[babyccino]

Related to #5287

This is a WIP but I just wanted to check if this is something Zed would be interested in before I put more time into it. Basically what I've done is changed the LSP functionality so labels as well as documentation is updated from the LSP completionItem/resolve response.

Before:

After:

[maxbrunsfeld]

The new labels look great. Could you explain a bit more about why the separate labels_for_resolved_completion method is needed?

[babyccino]

The new labels look great. Could you explain a bit more about why the separate labels_for_resolved_completion method is needed?

It's not completely necessary. You could definitely determine in the label function which kind of completion you're dealing with, but for the TS LSP (and maybe for others) the format is completely different depending on whether they are regular completions or resolved completions. I figured it was easier to do it this way and maybe there are some other LSPs where it's not so easy to differentiate.

[zed-industries-bot]

	Warnings
:warning:	This PR is missing release notes. Please add a "Release Notes" section that describes the change: Release Notes: - (Added|Fixed|Improved) ... ([#<public_issue_number_if_exists>](https://github.com/zed-industries/zed/issues/<public_issue_number_if_exists>)). If your change is not user-facing, you can use "N/A" for the entry: Release Notes: - N/A

Generated by :no_entry_sign: dangerJS against f4022972f6d56c1c9758ce4f90e5ed764ea9c9e7

[mrnugget]

Without having looked too closely at the code: @babyccino it might be worth checking against main and what has changed there, since I also changed the how we do completion item resolution: https://github.com/zed-industries/zed/pull/11157

[jackTabsCode]

Hi @mikayla-maki, I'm curious what the status of this is? Is it ready to be merged?

[babyccino]

Hi @mikayla-maki, I'm curious what the status of this is? Is it ready to be merged?

I got distracted by #12106 so I haven't worked on this in a while. It's still in a very rough state and definitely not ready to be merged. If Zed is still interested in this I can work on it after #12106 is merged

[ConradIrwin]

@babyccino I'm going to close for now, but please re-open when you get time to work on it!