zed icon indicating copy to clipboard operation
zed copied to clipboard

Add path option to Deno configuration

Open lino-levan opened this issue 1 year ago • 3 comments

Something that has been a little frustrating to me is that Zed isn't using the deno in my $PATH for the lsp. My understanding is that this is frowned upon in general, so instead of just using deno in the path, I have added a path configuration for the deno lsp so the user is able to specify which deno binary to use.

This is quite useful when switching between deno stable and deno canary.

Release Notes:

lino-levan avatar Apr 15 '24 22:04 lino-levan

My understanding is that this is frowned upon in general

Frowned upon by whom?

It's fairly common that our language servers respect the binary on the $PATH, if it happens to be there.

maxdeviant avatar Apr 15 '24 23:04 maxdeviant

Frowned upon by whom?

I had the impression from interacting with some people working on Zig support that this was something to be avoided. Not sure about the details. Happy to be wrong.

lino-levan avatar Apr 15 '24 23:04 lino-levan

@maxdeviant would you prefer that I simply read the PATH rather than add config? How can I push this PR forward?

lino-levan avatar Apr 19 '24 03:04 lino-levan

@lino-levan Deno support has been extracted to an extension in https://github.com/zed-industries/zed/pull/10912, after being unblocked by the work done as part of https://github.com/zed-industries/zed/issues/10906.

As part of extracting the Deno extension I added support for respecting the deno binary on the $PATH.

Will that be sufficient for your needs?

maxdeviant avatar Apr 24 '24 00:04 maxdeviant

Great, thanks for doing this.

lino-levan avatar Apr 24 '24 02:04 lino-levan