zed-industries
Use document window animation for “normal” windows
Release Notes:
- Added animation when opening new editor windows to match document windows on macOS, e.g. File > New in TextEdit or File > New > File… in Xcode.
https://github.com/zed-industries/zed/assets/31783266/91ff12e2-585d-46bd-9c3e-d71bc9a2c45a
https://github.com/zed-industries/zed/assets/31783266/cefc890d-35bb-4a8d-a64a-85c7a556c9d7
We require contributors to sign our Contributor License Agreement, and we don't have @lunacookies on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.
![cla-bot[bot] avatar](https://avatars.githubusercontent.com/in/2404?v=4 "Published by a pub.dev verified publisher"){kind=small}
I don't think we want this window open animation.
It increases the time it takes to open a new window, which I feel is undesirable for an editor like Zed.
You’re totally right about the speed aspect: of course, opening a new window now has a short delay.
My counter-argument is that the animation is brief and doesn’t have much easing, so at least to me it isn’t frustratingly slow in the way e.g. the animations in the macOS Control Center are. More importantly, seeing that animation upon opening a new window is the expected behavior, since it’s shared by all NSDocument-based applications on the system (QuickTime Player, Pages, Keynote, TextEdit, etc).
I realize that this really doesn’t matter though, so I don’t mind if you disagree and close this PR :)
Yeah, I have to also say that while I appreciate your work on this, I really don't like animations like these and would try to turn them off as soon as possible.
Okay, closing it for now. We can always reopen when someone really, really wants it. Seems like there's more push against animations for now.