zed icon indicating copy to clipboard operation
zed copied to clipboard

Terminal: `file://...:221:22` file links not clickable

Open jerrygreen opened this issue 10 months ago • 2 comments

Check for existing issues

  • [X] Completed

Describe the bug / provide steps to reproduce it

I know there this feature landed:

  • https://github.com/zed-industries/zed/pull/7312

But there still things to polish. For example, I see this link is being highlighted but not clickable:

Screenshot 2024-04-09 at 19 42 42

If I click it, nothing happens. It seems that :221:22 might break this functionality. This is often seen in file urls in stack traces to indicate position of where the error happened. IMO such links should be supported.

I've searched some issues, but they seem to be related to all other things:

  • https://github.com/zed-industries/zed/issues/9223 Editor-related. Like MD files etc. Not terminal
  • https://github.com/zed-industries/zed/issues/4310 Editor-related. Links inside hints.
  • https://github.com/zed-industries/zed/issues/7630 Terminal. But seems to be related to http(s) links, not file links

So this issue doesn't seem to be a duplicate to others.

Environment

copy system specs into clipboard doesn't work to me so here's some versions manually:

  • Zed 0.129.2
  • macOS Monterey 12.7.4

jerrygreen avatar Apr 09 '24 15:04 jerrygreen

It looks like we always treat file:// paths as URLs, which is why we struggle with colons for rows/columns

osiewicz avatar Apr 19 '24 11:04 osiewicz

I came to open a ticket for replicating, in the terminal, the CMD+Click-ability of URLs in the editor.

Seems like that might be a dupe or maybe a more general case of this ticket? Would be a nice, small improvement.

mattgiles avatar Apr 26 '24 00:04 mattgiles