zed-industries
Add theme VS Code Dark Modern
We require contributors to sign our Contributor License Agreement, and we don't have @TheWirv on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.
![cla-bot[bot] avatar](https://avatars.githubusercontent.com/in/2404?v=4 "Published by a pub.dev verified publisher"){kind=small}
@TheWirv How is this different from https://github.com/kcamcam/vscode_dark_modern.zed?
@TheWirv How is this different from https://github.com/kcamcam/vscode_dark_modern.zed?
I mean, I cannot from the top of my head tell you exactly which colors and which properties differ, but it is different. If you pull the two and make a diff, you would see. But I thought that wasn't a problem. There are quite a few seemingly "duplicate" extensions after all. Ultimately, mine is more accurate IMHO, considering Zed's theming "limitations".
@TheWirv How is this different from https://github.com/kcamcam/vscode_dark_modern.zed?
I mean, I cannot from the top of my head tell you exactly which colors and which properties differ, but it is different. If you pull the two and make a diff, you would see. But I thought that wasn't a problem. There are quite a few seemingly "duplicate" extensions after all. Ultimately, mine is more accurate IMHO, considering Zed's theming "limitations".
We try to avoid having duplicate extensions, especially when the only way to distinguish them by a user is a by looking for an extra - in the name.
@TheWirv How is this different from https://github.com/kcamcam/vscode_dark_modern.zed?
I mean, I cannot from the top of my head tell you exactly which colors and which properties differ, but it is different. If you pull the two and make a diff, you would see. But I thought that wasn't a problem. There are quite a few seemingly "duplicate" extensions after all. Ultimately, mine is more accurate IMHO, considering Zed's theming "limitations".
We try to avoid having duplicate extensions, especially when the only way to distinguish them by a user is a by looking for an extra
-in the name.
I understand, and what would you recommend doing now?
@maxdeviant I totally understand your point, but my theme is truly the most faithful adaptation, especially now that Zed has introduced the keyword.control option, and this theme is using it. However, I don't agree with you on the fact the "the only way to distinguish them by a user is a by looking for an extra - in the name", because most users will look for a theme on the Extensions tab in Zed. And over there the human-readable title and the description are featured, and they both make it very clear from my theme that it is the best choice for users who want the "VS Code Dark Modern" experience in terms of visuals. In the end, there are already three basically "VS Code Dark" themes, and I don't think a fourth one would make that situation a lot much worse.