extensions icon indicating copy to clipboard operation
extensions copied to clipboard

Shopify Liquid language support

Open RomainDW opened this issue 1 year ago • 1 comments

Check for existing issues

  • [X] Completed

Language

Liquid

Tree Sitter parser link

https://github.com/Shopify/tree-sitter-liquid

Language server link

https://shopify.dev/docs/themes/tools/cli/language-server

Misc notes

No response

RomainDW avatar Mar 12 '24 11:03 RomainDW

Looks like that tree-sitter grammar has been archived. There is a recent fork: https://github.com/hankthetank27/tree-sitter-liquid.

This is what nvim-treesitter references.

Also, here's a direct link to the LSP package

Depending on how this extension is implemented, it might need to use that package directly. Using the Shopify CLI will bring with it a bunch of other tooling that might not be needed.

Close inspection is needed.

jeffreyguenther avatar Apr 29 '24 17:04 jeffreyguenther

Is it planned to have the same functionality as the VSCode extension?

  • Code formatting
  • Code completion and documentation on hover
  • Liquid tag, filter and object
  • HTML tag, attribute and value
  • Theme, section and block settings
  • Theme translation
  • Render tag snippet
  • Code navigation
  • Auto-closing pairs
  • Theme checks and fixes

Symediane avatar May 30 '24 10:05 Symediane

@Symediane I'd love for the extension to have all the same functionality. The tools are available to make it possible.

I personally don't have a concrete plan to tackle the rest of the build at the moment. More likely, I'll chip away at things over time. I'm totally game to accept PRs or sponsorships that would allow me to dedicate the time to the work.

jeffreyguenther avatar May 30 '24 16:05 jeffreyguenther

We need this so badly 😄

mufftee avatar Jun 12 '24 22:06 mufftee

We do! It would make using Zed a dream for Shopify development. Let's see what I can do after Editions.

jeffreyguenther avatar Jun 12 '24 22:06 jeffreyguenther

Thank you! the syntax highlighter is already great move and help! Will be waiting for further improvements! Thank you so much @jeffreyguenther

Sanj718 avatar Jun 19 '24 18:06 Sanj718

There is now a Liquid extension.

SCR-20240716-mfee

JosephTLyons avatar Jul 16 '24 17:07 JosephTLyons

I don't think the extension was finished; it seems to me that the aim was to add the features listed by @Symediane

RomainDW avatar Jul 17 '24 07:07 RomainDW

Ya, that's correct. I started with Liquid syntax highlighting and am working towards creating an extension that does similar things to the official Shopify VSCode plugin. PRs are welcome on that repo. I'm chipping away at things between other projects.

jeffreyguenther avatar Jul 17 '24 16:07 jeffreyguenther