Tracking Issue: Extensions using `extension.json`

[maxdeviant]

This is a tracking issue for extensions still using the extension.json manifest format instead of extension.toml.

Extensions using extension.json

• [ ] assembly
  • Repository URL: https://github.com/DevBlocky/zed-asm
  • Issue: https://github.com/DevBlocky/zed-asm/issues/2
• [ ] asteroid
  • Repository URL: https://github.com/webhooked/asteroid-zed
  • Issue: https://github.com/webhooked/asteroid-zed/issues/2
• [ ] blackfox
  • Repository URL: https://github.com/matejcerny/BlackFoxZed
  • Issue: https://github.com/matejcerny/BlackFoxZed/issues/3
• [ ] blanche
  • Repository URL: https://github.com/kwonoj/zed-blanche
  • Issue: https://github.com/kwonoj/zed-blanche/issues/2
• [ ] cosmos
  • Repository URL: https://github.com/nauvalazhar/cosmos
  • Issue: https://github.com/nauvalazhar/cosmos/issues/3
• [ ] everforest
  • Repository URL: https://github.com/ThomasAlban/everforest-zed
  • Issue: https://github.com/ThomasAlban/everforest-zed/issues/9
• [ ] fish
  • Repository URL: https://github.com/hasit/zed-fish
  • Issue: https://github.com/hasit/zed-fish/issues/9
• [ ] fleet-themes
  • Repository URL: https://github.com/skarline/zed-fleet-themes
  • Issue: https://github.com/skarline/zed-fleet-themes/issues/6
• [ ] horizon
  • Repository URL: https://github.com/ayn2op/zed-horizon
  • Issue: https://github.com/ayn2op/zed-horizon/issues/3
• [ ] indigo
  • Repository URL: https://github.com/p3rception/Indigo-zed
  • Issue: https://github.com/p3rception/Indigo-zed/issues/2
• [ ] kiselevka
  • Repository URL: https://github.com/kdubrovsky/kiselevka-zed
  • Issue: https://github.com/kdubrovsky/kiselevka/issues/2
• [ ] ktrz-monokai
  • Repository URL: https://github.com/pcminh0505/ktrz-monokai-zed-theme
  • Issue: https://github.com/pcminh0505/ktrz-monokai-zed-theme/issues/1
• [ ] material-dark
  • Repository URL: https://github.com/xerodark/zed-material-theme
  • Issue: https://github.com/xerodark/zed-material-theme/issues/3
• [ ] matlab
  • Repository URL: https://github.com/rzukic/zed-matlab
  • Issue: https://github.com/rzukic/zed-matlab/issues/3
• [ ] mellow
  • Repository URL: https://github.com/sonodima/zed-mellow
  • Issue: https://github.com/sonodima/zed-mellow/issues/2
• [ ] muted
  • Repository URL: https://github.com/arifzeeshan/Muted
  • Issue: https://github.com/arifzeeshan/Muted/issues/2
• [ ] nanowise
  • Repository URL: https://github.com/Fastiraz/nanowise
  • Issue: https://github.com/Fastiraz/nanowise/issues/1
• [ ] napalm
  • Repository URL: https://github.com/napalmpapalam/napalm-theme-zed
  • Issue: https://github.com/napalmpapalam/napalm-theme-zed/issues/6
• [ ] night-owlz
  • Repository URL: https://github.com/elGusto/night-owlz
  • Issue: https://github.com/elGusto/night-owlz/issues/6
• [ ] nightfox
  • Repository URL: https://github.com/ssaunderss/zed-nightfox
  • Issue: https://github.com/ssaunderss/zed-nightfox/issues/4
• [ ] norrsken
  • Repository URL: https://github.com/webhooked/norrsken-zed
  • Issue: https://github.com/webhooked/norrsken-zed/issues/3
• [ ] one-hunter
  • Repository URL: https://github.com/teziovsky/zed-one-hunter-theme
  • Issue: https://github.com/teziovsky/zed-one-hunter-theme/issues/2
• [ ] quill
  • Repository URL: https://github.com/CraftQuill/zed-theme-quill
  • Issue: https://github.com/CraftQuill/zed-theme-quill/issues/2
• [ ] smithy
  • Repository URL: https://github.com/joshrutkowski/zed-smithy
  • Issue: https://github.com/joshrutkowski/zed-smithy/issues/2
• [ ] smooth
  • Repository URL: https://github.com/segersniels/zed-smooth
  • Issue: https://github.com/segersniels/zed-smooth/issues/3
• [ ] solarized-fp
  • Repository URL: https://github.com/lohazo/zed-solarized-fp
  • Issue: https://github.com/lohazo/zed-solarized-fp/issues/1
• [ ] srcery
  • Repository URL: https://github.com/srcery-colors/srcery-zed
  • Issue: https://github.com/srcery-colors/srcery-zed/issues/4
• [ ] strace
  • Repository URL: https://github.com/sigmasd/zed-strace
  • Issue: https://github.com/sigmaSd/zed-strace/issues/1
• [ ] syntax
  • Repository URL: https://github.com/syntaxfm/syntax-zed-theme
  • Issue: https://github.com/syntaxfm/syntax-zed-theme/issues/3
• [ ] synthwave
  • Repository URL: https://github.com/DanielMSchmidt/zed-synthwave
  • Issue: https://github.com/DanielMSchmidt/zed-synthwave/issues/6
• [ ] the-dark-side
  • Repository URL: https://github.com/Imgkl/the-dark-side
  • Issue: https://github.com/Imgkl/the-dark-side/issues/7
• [ ] vintergata
  • Repository URL: https://github.com/webhooked/vintergata-zed
  • Issue: https://github.com/webhooked/vintergata-zed/issues/2
• [ ] vscode-dark-plus
  • Repository URL: https://github.com/d1y/vscode_dark_plus.zed
  • Issue: https://github.com/d1y/vscode_dark_plus.zed/issues/9
• [ ] vscode-monokai-charcoal
  • Repository URL: https://github.com/d1y/vscode-monokaicharcoal.zed
  • Issue: https://github.com/d1y/vscode-monokaicharcoal.zed/issues/4
• [ ] warp-one-dark
  • Repository URL: https://github.com/distributed-intelligence/warp-one-dark
  • Issue: https://github.com/distributed-intelligence/warp-one-dark/issues/2
• [ ] wgsl
  • Repository URL: https://github.com/luan/zed-wgsl
  • Issue: https://github.com/luan/zed-wgsl/issues/4
• [ ] zedspace
  • Repository URL: https://github.com/Brunowilliang/zedspace
  • Issue: https://github.com/Brunowilliang/zedspace/issues/4

[sigmaSd]

I run a bot script, to open a PR with the needed changes for all the above repos, hopefully this make it easier and motivate the owners to migrate. https://github.com/sigmaSd/botfixzed/blob/master/bot.ts

[maxdeviant]

I run a bot script, to open a PR with the needed changes for all the above repos, hopefully this make it easier and motivate the owners to migrate. https://github.com/sigmaSd/botfixzed/blob/master/bot.ts

The script should also remove the extension.json in the PRs that it opens.

We don't want to end up with a bunch of extensions that have both an extension.toml and and extension.json, which seems to be what is happening.

[sigmaSd]

Yes because I wanted to do the least modifications possible, and noticed in testing that zed prioritize extension.toml that's why I thought its not that important.

[maxdeviant]

Yes because I wanted to do the least modifications possible, and noticed in testing that zed prioritize extension.toml that's why I thought its not that important.

Yes, but we want the extension.json gone. That is the whole point of this migration.

And the extension CI will fail when these authors go to publish a new version if they have both.

[sigmaSd]

I see, I'll update the PRs then.

[maxdeviant]

@sigmaSd Some of the PRs have other issues as well.

The one for zed-fish contained an extension.toml that was invalid and did not make the necessary removals to other files in the repo: https://github.com/hasit/zed-fish/pull/11

[sigmaSd]

For that extension in particular , I did test manually and I noticed the grammar, but I left it because the extension still works, the PRs were meant as a minimum working changes while the author do the clean up and gets motivated to update.

I have the script running now pushing a commit to remove extension.json to all the open prs it made. but I'm not going to make it do more, the extension author have to test it manually and do the needed cleanup.

[sigmaSd]

Actually the grammars changes seems straight forward, maybe I'll add that

[sigmaSd]

@maxdeviant I'll update the script with you recommendations, currently this is what I'm going to do

• remove grammar = type
• remove grammer folder
• remove languages key
• if there is already a [grammar] dict remove it
• add grammar to gitignore

[sigmaSd]

I update all the pr as discussed, is there more feedback ?

[maxdeviant]

I update all the pr as discussed, is there more feedback ?

Thank you! I think that should be all that is needed.

Sorry if I came off a bit blunt, I just want to make sure that we're helping out maintainers and not creating more work for them.

I do appreciate you helping out with this migration 🙂

[sigmaSd]

No problem, that makes sense thanks as well