extensions icon indicating copy to clipboard operation
extensions copied to clipboard

Helm (`helm`) extension support

Open hjoshi123 opened this issue 11 months ago • 11 comments

I'm fairly new to language configuration, lsp and tree sitter and was working on Helm charts so decided to create an extension for go templates.

Kindly let me know if something is missing.

hjoshi123 avatar Feb 26 '24 04:02 hjoshi123

We require contributors to sign our Contributor License Agreement, and we don't have @hjoshi123 on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

cla-bot[bot] avatar Feb 26 '24 04:02 cla-bot[bot]

@cla-bot check

hjoshi123 avatar Feb 26 '24 04:02 hjoshi123

The cla-bot has been summoned, and re-checked this pull request!

cla-bot[bot] avatar Feb 26 '24 04:02 cla-bot[bot]

@maxdeviant should the repo name for grammar be tree-sitter-helm? because its not that

hjoshi123 avatar Feb 26 '24 16:02 hjoshi123

@maxdeviant should the repo name for grammar be tree-sitter-helm? because its not that

Hmm, I'm not 100% sure how the name of the resulting Wasm grammar is determined.

@maxbrunsfeld Do you know?

maxdeviant avatar Feb 26 '24 16:02 maxdeviant

@maxbrunsfeld how should I handle this? Should I change the name of the extension and folders so that it matches the repository of tree sitter?

hjoshi123 avatar Mar 04 '24 07:03 hjoshi123

@maxbrunsfeld how should I handle this? Should I change the name of the extension and folders so that it matches the repository of tree sitter?

yes

cabrinha avatar Mar 17 '24 18:03 cabrinha

@maxbrunsfeld please do the needful

cabrinha avatar Mar 20 '24 15:03 cabrinha

@hjoshi123 please do the needful

cabrinha avatar Apr 02 '24 14:04 cabrinha

@hjoshi123 please do the needful

@cabrinha Please stop spamming this PR with messages like this. At this point we're aware of your desire for this extension.

Comments like this are just noise and are not doing anything in terms of making this work proceed any faster. If you would like to see this work proceed faster, consider helping out with the necessary changes.

maxdeviant avatar Apr 02 '24 14:04 maxdeviant

@hjoshi123 please do the needful

@cabrinha Please stop spamming this PR with messages like this. At this point we're aware of your desire for this extension.

Comments like this are just noise and are not doing anything in terms of making this work proceed any faster. If you would like to see this work proceed faster, consider helping out with the necessary changes.

Thanks, here is my PR: https://github.com/zed-industries/extensions/pull/443

cabrinha avatar Apr 04 '24 15:04 cabrinha

Closing due to inactivity.

maxdeviant avatar May 16 '24 21:05 maxdeviant