Add Gruvbox-ish

[tristan-f-r]

adds the gruvbox-ish theme (original).

Note: I have not explicitly licensed the previous repository. I've contacted the author of gruvbox-ish by email, where they said "Of course you can port/modify or do whatever you want with it." If there's some extra requirement for licensing, I can ask for explicit licensing 👍

[cla-bot[bot]]

We require contributors to sign our Contributor License Agreement, and we don't have @LeoDog896 on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

[tristan-f-r]

@cla-bot check

[cla-bot[bot]]

The cla-bot has been summoned, and re-checked this pull request!

[morgoth]

@LeoDog896 There is a builtin gruvbox theme in zed editor. Maybe it would be possible to port the improvements directly there? I'm not familiar with changes/content, so not sure if it's easy and it won't break anything else, but would be cool to have solid gruvbox theme out of the box.

[tristan-f-r]

I could, though that doesn't seem appropriate given the themes changes and relative unpopularity in vscode - this theming extension only has 8 thousand downloads on VSCode.

[khipp]

@LeoDog896 There is a builtin gruvbox theme in zed editor. Maybe it would be possible to port the improvements directly there? I'm not familiar with changes/content, so not sure if it's easy and it won't break anything else, but would be cool to have solid gruvbox theme out of the box.

There was a similar discussion when the Rosé Pine theme was added. The official stance was not to change the built-in themes but to add an extension: https://github.com/zed-industries/zed/issues/9151#issuecomment-1988541178

[morgoth]

Thank you for checking

[tristan-f-r]

Thanks for the PR!

Could you update the ID in your extension.toml to be just gruvbox-ish instead of zed-gruvbox-ish?

https://github.com/LeoDog896/zed-gruvbox-ish/blob/e8bda4473ef8a5057c409b4799f0d71dcf6ab93c/extension.toml#L1

👍