Holger Freyther
Holger Freyther
LGTM. Definitely closes a time of check/time of use kind of problem. Now Set/DeleteIf/gc are protected by the same mutex.
Any chance you have the configuration around?
Any chance the example needs to have a "continue" to match the second route?
> Yes it does :) I missed that in the example! What if we don't attempt to fix this without requiring extra configuration? What if a future version of AM...
@grobinson-grafana A full mr and separating the snapshot-ing from the behavior change. The failing test seems unrelated.
How can we make progress on this change? I am happy to help reviewing other people changes to increase the bench of reviewers...
I don't know your taste. I can start using pcap.DLT_RAW and pcap.DLT_RAW (which in turn would return C.DLT_RAW) to make this work universally. The reason I didn't do it yet...
It is based on the PR for DLT_RAW. I don't comprehend the relationship between LayerType and EnumMetadata yet. In the EnumMetadata instance one can refer a LayerType (and that is...
I have done so and had to fix some testcases. Do you want to enable travis-ci support for your clone to see if I should fix things here as well?
Done that but looking at the build log I wonder.. ``` The command "go test github.com/google/gopacket/layers" exited with 0. 0.68s$ go test github.com/google/gopacket/tcpassembly ok github.com/google/gopacket/tcpassembly 0.147s ``` shouldn't this be...