AFK-Daily icon indicating copy to clipboard operation
AFK-Daily copied to clipboard

Add VIP & Campaign in config

Open kevingrillet opened this issue 4 years ago • 6 comments

Fix #104 & #103

kevingrillet avatar Sep 27 '21 15:09 kevingrillet

Should work, but need to be tested ;)

kevingrillet avatar Oct 21 '21 08:10 kevingrillet

After merge with #133 will require to update the wiki examples 😉

kevingrillet avatar Oct 23 '21 18:10 kevingrillet

Note to self:

  • [x] Update Wiki page AFK Arena requirements with correct values found here.

Zebiano avatar Oct 25 '21 23:10 Zebiano

I'll work on it next week if my test account gets back to work. But I think we already did 99% of the work.

kevingrillet avatar Jan 06 '22 07:01 kevingrillet

I've been taking a look at this, and I think I want to make it a bit more different. I'd rather have a function dedicated to checking everything related to required levels/stages before executing the init function, rather than cluttering up the main "if doAction then doAction" section of the file with requirement checks.

~~I'm still unsure if we should exit the script if we found stuff the user has invalid requirements, or take other actions instead.~~ I've decided to let the script take actions automatically. This means the script will warn the user "Yo, I can't do that!" and then proceed to either do something that it can do or skip it. I think this is the best approach, as else it would defeat the purpose of having a feature that checks for player levels, etc, as it would simply be annoying for everyone and no one would make use of it.

I'll take care of it this week hopefully!

Zebiano avatar Jan 17 '22 00:01 Zebiano

Alright, the PR is basically done now: VIP, Chapter and Stage are now settable in the config, and it also fixes (hopefully) #118 and #103. It could be merged like this, yet it's fairly simple to implement the rest of the necessary changes to take lower-level Players into consideration, so I'm considering doing that. I guess my plan is to create some more issues and then either fix them on this PR or "per issue" in the future.

Zebiano avatar Jan 31 '22 02:01 Zebiano