zebmason

Results 20 comments of zebmason

@CloneDeath I found with #213 that it just started to grow and grow then the merge conflicts turned it to hell. I like the bounding box code that I wrote...

Do you mean the line in [SetupModel.cpp](https://github.com/mrc-ide/covid-sim/blob/dfc6402db34c174e41d9afcba3b4f49d7ff1f425/src/SetupModel.cpp#L168)?

From a previous conversation with @matt-gretton-dann * member variables are snake_case_ with trailing underscore * methods are snake_case() * classes / structs are CamelCase

@matt-gretton-dann Just initial grouping of logically related values so as to reduce the number of elements in params.

@matt-gretton-dann Perhaps I should have mentioned that I've been further developing my code analysis tool to factor out classes from dependencies so my commits since I stopped playing with GoogleTest...

@Feynstein @ozmorph Yohan no you can't do that for #228. The build is C++11, std::filesystem is C++17. git submodules seem to be ignored by the CI system so you won't...

@Feynstein Yohan there is a backport of std::filesystem that I've used in the past and I have a approved commit for C++14 (#207) and may get submodules sorted due to...

Lots of dead code knocking around - I couldn't understand the point of periodic boundaries. You have to track the conversions so that the expression has consistent units. P.S. I...