ruby-acme-cli icon indicating copy to clipboard operation
ruby-acme-cli copied to clipboard

`certificate_exists_and_valid_and_all_domains_included?` is confusing

Open troelskn opened this issue 9 years ago • 0 comments

The method returns false or exits. From the name, one would assume it to return a boolean in all cases. Either the method should be renamed (To something like ensure_certificate_exists_and_valid_and_all_domains_included! perhaps) or it should return true instead of exit 2. The latter is probably better, but would require calling code to change.

troelskn avatar Aug 22 '16 14:08 troelskn