zeal icon indicating copy to clipboard operation
zeal copied to clipboard

Full dark theme

Open eromoe opened this issue 6 years ago • 8 comments

Previous issue https://github.com/zealdocs/zeal/issues/466 add Dark Mode which only make main window dark. But that looks incongruous with other parts, especially left sidebar looks too shinning in dark mode.

Hope can embed a full dark theme .

eromoe avatar Nov 02 '17 00:11 eromoe

Does this make sense? I think it would require a lot of UI rewriting to achieve or design a stylesheet? Maybe it's just better left as it is currently, at user option to match widgets with the system or specific style:

oblitum avatar Nov 04 '17 19:11 oblitum

@oblitum I guess this is more of an issue for Windows users, who do not have all the flexibility Linux DEs provide.

Styling Qt apps works on Windows as well, but most people are just not aware of it. So, I think the first step would be providing some docs on how to change Zeal's appearance with third party themes for Qt.

trollixx avatar Nov 05 '17 11:11 trollixx

I haven't tried QDarkStyleSheet yet, but it looks promising.

trollixx avatar Dec 05 '17 21:12 trollixx

Agreed!

oblitum avatar Dec 05 '17 22:12 oblitum

For those still looking for a solution: Installing Kvantum worked for me. Note that after installing you need to follow the instructions on setting it as the default.

nzig avatar May 14 '21 19:05 nzig

For those still looking for a solution: Installing Kvantum worked for me. Note that after installing you need to followe the instructions on setting it as the default.

For those on Windows, no solution, apparently.

I don't understand why make a darkmode that only applies to a certain part of the window, but anyways.

ezxpro avatar Jun 08 '21 14:06 ezxpro

I don't understand why make a darkmode that only applies to a certain part of the window, but anyways.

@ezxpro because people with decent OS can then couple it to their dark desktop environment.

Zeal can only do its best to provide flexibility where it can (Qt styling), not where it cannot (Window decorations), that's generally responsibility of the OS.

oblitum avatar Jun 09 '21 00:06 oblitum

QT tacking bug here https://bugreports.qt.io/browse/QTBUG-72028?focusedCommentId=677819&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-677819:

Note for those wanting to enable the experimental dark mode support (much improved in upcoming 6.4) for your application from code: you can call

qputenev("QT_QPA_PLATFORM", "windows:darkmode=1/2");

in your main function before instantiating Q(Gui)Application.

  • darkmode=1 means: dark window frame if the palette is explicitly made dark (background color darker than foreground color) and the system runs in dark mode.
  • darkmode=2 means: the palette is dark, based on system colors; the Window Vista style is still ignoring that, using the UXTheme provided control primitives (and there is no native API to get dark versions of those, to my knowledge). Fusion style looks quite good though

ashb avatar Sep 14 '22 08:09 ashb

@ezxpro because people with decent OS can then couple it to their dark desktop environment.

If that's the case, Zeal should not support Windows at all, so a different project can fill in the gap. Only half-supporting a platform ensures no-one will use it on that platform, an no alternatives get build over time.

K8-and-a-half-1000 avatar Jan 30 '23 12:01 K8-and-a-half-1000

Looks like with Qt 6.5 we can get a dark mode support with Fusion theme. It doesn't look native but not too bad overall. To be honest, Qt never got Windows Vista style to look native either. I think falling back to the Fusion theme is a good compromise.

trollixx avatar Apr 16 '23 03:04 trollixx

Sneak peek below. Also includes native Chromium dark mode.

image

The Fusion style looks quite good in the light mode too:

image

I am kind of inclined to make Fusion the default style on Windows.

trollixx avatar Apr 16 '23 04:04 trollixx

Sneak peek below. Also includes native Chromium dark mode.

Ok, great, but how can I use it on Windows?! I'm still getting this horrendous glaring white sidebar on the left and on the top even when setting the mode to Dark in version 0.6.1

image

ruslaniv avatar Jul 23 '23 16:07 ruslaniv

@ruslaniv this change is available in the main branch. You can try CI builds until new version is released. Binary artifacts are attached to each build.

trollixx avatar Aug 08 '23 04:08 trollixx