zeal
zeal copied to clipboard
zealdocs
Highlighted search results are unreadable when using a dark theme
I'm running Zeal under Gnome using the adwaita-dark theme, and have this environment variable set to make Qt applications match the theme:
export QT_STYLE_OVERRIDE=Adwaita-Dark
When I search for something, the highlighted part of the list of results is unreadable, as seen in the screenshot below:
Definitely a bug, but may be tricky to fix. The highlighting is inspired by Windows Explorer, but it's a simple overlay. To render properly the color of the underlying letters needs to be reversed. Will check how Windows does it with the new dark theme.
Maybe a simpler fix would be to change the opacity of the yellow overlay to something like 0.5?
Hello, I had fixed this problem in pull request #1124.
@trollixx If you like, I create a new solution for a dark ui based on QPalette. This should be less problematic than the CSS solution.
@kaygdev I check the old PR, the relevant change from it should work, but need to detect the dark theme. Need to check if Qt has anything for that.
In this PR I have introduce a UI Style option in Preferences/General. At this option, you can choose between the system default, the dark style and a custom CSS.
The dark style apply a shipped CSS file and I see the drawback of it. In another project I made good experiences with the QPalette in combination with the fusion style for a dark UI. I think this can also be a good solution for zeal.
It's something I'd definitely be interested to look at. Relying on unsupported 3rd party style is risky, but if we can provide a relatively good experience with the Fusion style, that should be better than nothing.
Same problem here til now for Zeal 0.6.2-dev.212+8a018dc, is any fixed patchs can merged to master?
Any updates on this, or any workarounds? I see you can point to a custom CSS in the settings, but not sure if that applies to the sidebar too, or what classes to override.
@trollixx Thank you for this wonderful application. Is there a known fix for this as it makes my life miserable :)
This issue is highly theme dependent. Proper fix requires quite a bit more complex logic in how search item delegate renders text.
A temporary workaround for this would be switching to another UI style. For me Fusion style renders everything quite nicely. To test it, run Zeal with -style fusion argument.
Any ideas how to pass command line args when zeal is installed as a flatpak? I've used flatseal to set env vars such as for Qt, but it does not seem to control command line arguments. I also couldn't locate a desktop file for the zeal flatpak. :thinking:
@mttkay I think it is flatpak run org.zealdocs.Zeal -style fusion. I haven't tried though.
Zeal 0.6.1 under Gnome using the adwaita-dark theme with export QT_STYLE_OVERRIDE=Adwaita-Dark actually looks awesome, right out of the box :-)
What formerly (3 years ago) was grey now is white and perfectly readable on yellow
Using Zeal 0.7.0 and Adwaita-Dark 1.4.2 the search highlight is still unreadable :(
