gpx-animator icon indicating copy to clipboard operation
gpx-animator copied to clipboard

Add support to render the name of a track in the animation

Open therealrobster opened this issue 2 years ago • 7 comments

Hi,

I've noted in the rendered video file, the description down the bottom shows and changes with each GPX file. But, after a couple of GPX files, the description doesn't update. It keeps saying the same description for the rest of the video.

I'm running from the command line like so:

#!/bin/bash

# reads all the GPX files in a folder and outputs a video using GPX-ANIMATOR

clear

echo "Processing the following files : "

VAR=""
dir=~/Sync/Phone-Data/MappingExercise/gpxFiles
for f in "$dir"/*; do
	echo ${f}
    VAR+="--input ${f} "
done


java -jar ~/Applications/gpx-animator/gpx-animator-1.7.0-all.jar --tms-url-template ' https://{switch:a,b,c}.tile.openstreetmap.org/{zoom}/{x}/{y}.png' --font Monospaced-PLAIN-28 --background-map-visibility 0.5 --width 4096 --height 2160 --viewport-width 1280 --viewport-height 720 --total-time 1800000  --line-width 3 --viewport-inertia 30 --margin 100 --marker-size 12 --fps 60 --tail-duration 200000 --keep-last-frame 2000 --attribution-position hidden --information-position 'hidden' --comment-position 'bottom right' $VAR --output ~/Videos/BikeRides.mp4

I never noticed it when I only had a few GPX files, but I'm up to 14 in that folder now and I'm seeing the behavior after about the 3rd or 4th file is processed.

If I can supply any other info please say. I'm happy to supply the files and video, but I'd have to do that privately due to having my home address shown so clearly.

Thank you

therealrobster avatar Feb 24 '22 10:02 therealrobster

What do you mean by "description"? Do you mean the comment? In that case, it is easy to explain: Depending on the speed of the video a track point might be only shown for a few milliseconds. Not long enough for a viewer to read the comment. So we decided to display the comment longer than a track point will be shown. We show it until a new comment shows up in one of the following track points, which might be an empty comment.

McPringle avatar Jul 17 '22 16:07 McPringle

I'll show you a video, to show that it's definitely an issue that can't be ignored for proper usage of the software. But I'd need to share it with you privately as it has my home address being shown on the maps. Is there a way I can email or similar the video link to you to show the issue? Thanks so much

therealrobster avatar Jul 18 '22 00:07 therealrobster

Sure, you can send it to my private email address: [email protected]

McPringle avatar Jul 19 '22 06:07 McPringle

I've just emailed that now, thank you for the offer.

therealrobster avatar Aug 02 '22 00:08 therealrobster

Today at the Hackergarten event in Lucerne we have been working on this issue. GPX Animator is ignoring the description elements, but reads the comment elements. GPX Animator can actually only handle comments on track points. The comments in your GPX files are at the GPX meta data and track level. These should not show up in the video at all. GPX Animator did not expect these comments there and the parser messed it up. That is the reason why some comments where rendered and others not. Same happened with the name element. GPX Animator expects the name element only for way points.

Thanks to your report we have started rewriting the GPX parser and make it more solid. The result is the correct parsing of the GPX file and your name and comment elements will not show up in the video any more (because they are not part of a track point or way point).

To display the names of the tracks in the animation, we will need to implement this as a new feature. This should not be too complicated, but needs some refactoring of the code base.

McPringle avatar Apr 06 '23 20:04 McPringle

Issue #514 needs to be solved first.

McPringle avatar Apr 07 '23 12:04 McPringle

Brilliant, thank you for this. I do appreciate it. Glad I was able to provide the info needed. I appreciate everyone's efforts tremendously.

therealrobster avatar Apr 08 '23 06:04 therealrobster