ATen

ATen copied to clipboard

Improve error messages for undefined tensors

2

Tensor objects do not have to be defined: ``` Tensor foo; // undefined tensor reference auto zeros = CPU(kFloat).zeros({3,4}); // will crash because foo is not defined. add_out(zeros,zeros,foo); ``` In...

zdevito

Const-correctness

7

ATen is presently has no const modifiers, even for methods which are obviously const (e.g. `virtual bool isCuda()` in Type). Make it more const-correct.

ezyang

btrifact() may dereference nullptr

3

Here is the generated code: ```c++ std::tuple CPUFloatType::btrifact(const Tensor & info, bool pivot, const Tensor & self) { auto result_ = new CPUFloatTensor(context); auto result = Tensor(result_,false); auto pivots_ =...

colesbury

Here is a self-contained repro: ``` [[email protected] ~/local/c2isl/third-party/pytorch] python --version Python 2.7.5 [[email protected] ~/local/c2isl/third-party/pytorch] python foo.py Traceback (most recent call last): File "foo.py", line 3, in re.compile(x, re.MULTILINE) File "/usr/lib64/python2.7/re.py",...

ezyang

If a user decides to convert an ATen tensor into a dlpack/numpy one, sharing underlying data, we MUST NOT resize the tensor. Unfortunately, there is no way in the current...

ezyang

Similar to the size language of the original aten, but implemented as C++ utility functions that match dimensions of tensors to variables and report and error if a variable is...

zdevito

I have a very hard time understanding, which AT_DISPATCH from [here](https://github.com/zdevito/ATen/blob/master/aten/src/ATen/Dispatch.h) needs to be used in order to write tensors of different dtypes to a kernel. While I understand, how...

unholdmx

Is there a way we can begin support for Metal in the apple ecosystem? I think there would be a 'market' for that so to speak.

JudeDavis1