ATen icon indicating copy to clipboard operation
ATen copied to clipboard

Fix include file ordering issues.

Open zdevito opened this issue 6 years ago • 0 comments

Currently when you include ATen/Tensor.h in a compilation unit, you also need to include ATen/TensorMethods.h. This is handled by including ATen/ATen.h, but since we do no checks about what clients include, sometimes only Tensor.h gets included.

We can fix this by restricting what clients can include to only ATen/ATen.h. I am not sure what the right C++ mechanism is for enforcing this.

We should also figure out how to install only the user-facing header files (Tensor.h, Type.h) and not the implementation-only header files (CPUFloatTensor.h) which are only used in the build process.

zdevito avatar Sep 27 '17 17:09 zdevito