telseq
telseq copied to clipboard
version of software doesn't match repo tag
Built image by downloading tagged version v0.0.2
Program: TelSeq
Version: 0.0.1
This is caused by the dockerfile specifying the tag instead of using the code that is local to the dockerfile. Although it's common practice to have a dockerfile that is stand alone, it is less error prone to expect the file to be colocated with the code it relates to.
Also version is hardcoded to 0.0.1 in the following files for the 0.0.2 tagged release:
$ grep -r 0.0.1 .
./src/config.h:#define PACKAGE_STRING "TelSeq 0.0.1"
./src/config.h:#define PACKAGE_VERSION "0.0.1"
./src/config.h:#define VERSION "0.0.1"
./src/configure.ac:AC_INIT([TelSeq], [0.0.1], [[email protected]])
./Dockerfile:LABEL Description="Telseq docker" Version="0.0.1"
If repo is available local to Dockerfile the following will allow people to generate a docker image that reports correct versions:
$ git diff
diff --git a/Dockerfile b/Dockerfile
index 8dafc35..681e51c 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -1,7 +1,7 @@
FROM ubuntu:14.04
MAINTAINER Zhihao Ding <[email protected]>
-LABEL Description="Telseq docker" Version="0.0.1"
+LABEL Description="Telseq docker" Version="0.0.2"
VOLUME /tmp
@@ -37,17 +37,12 @@ RUN mkdir -p /deps && \
# build telseq
-RUN mkdir -p /src && \
- cd /src && \
- wget https://github.com/zd1/telseq/archive/v0.0.1.tar.gz && \
- tar -xzvf v0.0.1.tar.gz && \
- rm v0.0.1.tar.gz && \
- cd telseq-0.0.1/src && \
+COPY src /tmp/src
+RUN cd /tmp/src && \
./autogen.sh && \
./configure --with-bamtools=/deps/bamtools-2.4.0 --prefix=/usr/local && \
make && \
make install
-
ENTRYPOINT ["/usr/local/bin/telseq"]
-CMD ["--help"]
\ No newline at end of file
+CMD ["--help"]
diff --git a/src/config.h b/src/config.h
index 2cc99d5..8d9ce24 100644
--- a/src/config.h
+++ b/src/config.h
@@ -38,7 +38,7 @@
#define PACKAGE_NAME "TelSeq"
/* Define to the full name and version of this package. */
-#define PACKAGE_STRING "TelSeq 0.0.1"
+#define PACKAGE_STRING "TelSeq 0.0.2"
/* Define to the one symbol short name of this package. */
#define PACKAGE_TARNAME "telseq"
@@ -47,10 +47,10 @@
#define PACKAGE_URL ""
/* Define to the version of this package. */
-#define PACKAGE_VERSION "0.0.1"
+#define PACKAGE_VERSION "0.0.2"
/* Define to 1 if you have the ANSI C header files. */
#define STDC_HEADERS 1
/* Version number of package */
-#define VERSION "0.0.1"
+#define VERSION "0.0.2"
diff --git a/src/configure.ac b/src/configure.ac
index 73cc4da..d369f1e 100755
--- a/src/configure.ac
+++ b/src/configure.ac
@@ -2,7 +2,7 @@
# Process this file with autoconf to produce a configure script.
AC_PREREQ([2.69])
-AC_INIT([TelSeq], [0.0.1], [[email protected]])
+AC_INIT([TelSeq], [0.0.2], [[email protected]])
AM_INIT_AUTOMAKE(foreign)
AC_CONFIG_SRCDIR([Telseq/telseq.cpp])
AC_CONFIG_HEADERS([config.h])