gulp-css-base64 icon indicating copy to clipboard operation
gulp-css-base64 copied to clipboard

Feat: Add option for custom regexp

Open hacke2 opened this issue 8 years ago • 15 comments

  1. 'Object.assign' replace 'JSON.parse(JSON.tringify(opts))'
  2. support custom rImages regexp

Resolve zckrs/gulp-css-base64#28

hacke2 avatar Apr 13 '16 12:04 hacke2

@zckrs

hacke2 avatar Apr 13 '16 12:04 hacke2

https://travis-ci.org/zckrs/gulp-css-base64/jobs/122771422#L504

zckrs avatar Apr 13 '16 12:04 zckrs

I can't find the .eslintrc in gulp-css-base64

hacke2 avatar Apr 13 '16 12:04 hacke2

eslintrc is deprecated

see https://github.com/zckrs/gulp-css-base64/blob/master/package.json#L49

zckrs avatar Apr 13 '16 12:04 zckrs

Coverage Status

Coverage remained the same at 99.13% when pulling 3117bef695c78092fb98c6d9bd3622800734b93e on hacke2:master into b63225ede3ed711e579fb0b7ca09ff16ddae6221 on zckrs:master.

coveralls avatar Apr 13 '16 12:04 coveralls

I forget has Node version less than 4...My company used 4 or 5....

hacke2 avatar Apr 13 '16 12:04 hacke2

Yeah :S sorry. Actually this plugin work well with 0.12 and 0.10.

zckrs avatar Apr 13 '16 12:04 zckrs

You should remove Object.assign :S

zckrs avatar Apr 13 '16 12:04 zckrs

Why do you think should not modify original options object?

hacke2 avatar Apr 13 '16 12:04 hacke2

IMO if you want pass regex in json option you should use new RegExp constructor and toString

zckrs avatar Apr 13 '16 13:04 zckrs

User must use string replace regex in option?

hacke2 avatar Apr 13 '16 13:04 hacke2

Coverage Status

Coverage increased (+0.007%) to 99.138% when pulling fb0d3e0cee92d158b2076eac96b7d3fab739e0ce on hacke2:master into b63225ede3ed711e579fb0b7ca09ff16ddae6221 on zckrs:master.

coveralls avatar Apr 14 '16 02:04 coveralls

Coverage Status

Coverage increased (+0.007%) to 99.138% when pulling d77188eeb6aeb2aeda33fee086638241fb8ff189 on hacke2:master into b63225ede3ed711e579fb0b7ca09ff16ddae6221 on zckrs:master.

coveralls avatar Apr 14 '16 02:04 coveralls

Coverage Status

Coverage remained the same at 99.13% when pulling 46c1c6a1f9e5ccb05fc323676c8693b3b0d0a6f9 on hacke2:master into b63225ede3ed711e579fb0b7ca09ff16ddae6221 on zckrs:master.

coveralls avatar Apr 14 '16 02:04 coveralls

Coverage Status

Coverage remained the same at 99.13% when pulling c8259f1ddc6bf3327c87931a5e52a038f2abbf02 on hacke2:master into b63225ede3ed711e579fb0b7ca09ff16ddae6221 on zckrs:master.

coveralls avatar Apr 14 '16 06:04 coveralls