Chenyu Zhao

Results 27 comments of Chenyu Zhao

Okay I think I found the issue: https://github.com/mittwald/go-helm-client/blob/43db5e2a1d107a2e3a845ad228b8a14824f8cc32/client.go#L784 If Namespace is not set in ChartSpec to default to the "default" namespace, this equality will fail. I think we need to...

Actually, this doesn't work 100% of the time since sometimes `r.Namespace` is `"default"` and sometimes it's `""`. I think it might depend on how the chart was installed.

PR with fix: https://github.com/mittwald/go-helm-client/pull/162

+1 I was just looking for this You can use a tool like https://github.com/uber-go/mock to easily auto-gen it

@bwplotka Those are good points. Fakes are indeed preferable to mocks when possible. I also see your point about there not being a standard mocking framework, that indeed throws a...

Adding `podmonitorings` to `gmp-system:operator` fixes it ``` --- # Source: operator/templates/role.yaml apiVersion: rbac.authorization.k8s.io/v1 kind: ClusterRole metadata: name: gmp-system:operator rules: # Resources controlled by the operator. - resources: - clusterpodmonitorings -...