zcash-android-wallet-sdk icon indicating copy to clipboard operation
zcash-android-wallet-sdk copied to clipboard

Published 20 hours ago • verified publisher icon zcash

Move regex filters out of the Strings

Open HonzaR opened this issue 1 year ago • 0 comments

Describe the issue

After some troubles with pseudo-locales in the Secant wallet project, while running screenshot tests, we've decided to move the co_electriccoin_zcash_zec_amount_regex_continuous_filter and co_electriccoin_zcash_zec_amount_regex_confirm_filter out of the strings and have them placed just as constants possibly in the related ZecStringExt component.

This issue represents the actual trouble in the Secant wallet: https://github.com/zcash/secant-android-wallet/issues/817

And this is the original PR of the filters feature: https://github.com/zcash/secant-android-wallet/pull/295

Expected behaviour

We'll get rid troubles of pseudo-locales while doing the screenshot test

HonzaR avatar Mar 28 '23 12:03 HonzaR