zcash-android-wallet-sdk icon indicating copy to clipboard operation
zcash-android-wallet-sdk copied to clipboard

CompactBlockProcessor - address TODOs from code base

Open HonzaR opened this issue 2 years ago • 0 comments

Is your feature request related to a problem? Please describe.

Filling an additional issue to provide a link to the code base TODO occurrence. This should be ideally split into several more detailed issues once we're on solving it.

TODOs overview:

  • ~~updateRanges: rethink this and make it easier to understand what's happening. Can we reduce this so that we only work with actual changing info rather than periodic snapshots? Do we need to calculate these derived values every time?~~
  • ~~we still need a way to identify those transactions that failed to be enhanced~~
  • refreshUtxos: cleanup the way that we prevent this from running excessively. For now, try for about 3 blocks per app launch. If the service fails it is probably disabled on ligthtwalletd, so then stop trying until the next app launch.
  • processUtxoResult: more accurately track the utxos that were skipped (in theory, this could fail for other reasons)
  • getNearestRewindHeight: add a concept of original checkpoint height to the processor. For now, derive it add one because we already have the checkpoint. Add one again because we delete ABOVE the block.

HonzaR avatar Aug 19 '22 09:08 HonzaR