sapling-crypto icon indicating copy to clipboard operation
sapling-crypto copied to clipboard

Fix test_uint32_shr failing on debug builds.

Open defuse opened this issue 6 years ago • 1 comments

This makes shr behave differently than Rust's >> in release mode but IMO how >> works in release mode is kinda dumb -- I could see myself assuming the argument to shr or the right argument to >> saturates instead of taking the value mod 32, and introducing security bugs that way -- so this seems safer.

defuse avatar Feb 19 '19 19:02 defuse

This PR would need to be migrated over to the main rust crates.

str4d avatar Nov 14 '19 10:11 str4d