lightwalletd icon indicating copy to clipboard operation
lightwalletd copied to clipboard

Support gRPC over websocket to allow direct access from browsers

Open arya2 opened this issue 2 years ago • 8 comments
trafficstars

Motivation

Using lightwalletd from the browser currently requires a proxy server to provide an http/1.1 transport. or gRPC over websocket.

Integrating gRPC over websocket support will offer web developers the direct access to lightwalletd that native developers currently enjoy.

arya2 avatar Aug 18 '23 22:08 arya2

I asked chatGPT about this -- did I ask the question correctly? https://chat.openai.com/share/02a1ba5b-217f-42a4-986d-d191f70866c3

It seems to suggest supporting websocket but maybe not http/1.1. Is that acceptable? (I really don't understand this area very well.)

LarryRuane avatar Aug 19 '23 02:08 LarryRuane

Can you provide some motivation for this? I would have to justify spending time on this (if possible), thanks.

LarryRuane avatar Aug 19 '23 02:08 LarryRuane

It seems to suggest supporting websocket but maybe not http/1.1. Is that acceptable? (I really don't understand this area very well.)

That would be ideal, I'm not sure if http/1.1 would support the streams, and websockets offer more flexibility / lower latency.

arya2 avatar Aug 19 '23 02:08 arya2

Hey @LarryRuane how is this going?

borngraced avatar Oct 02 '23 10:10 borngraced

I'm just getting around to this finally, sorry for the delay, I'll try to get this done within the next week or so.

LarryRuane avatar Nov 03 '23 14:11 LarryRuane

It seems to suggest supporting websocket but maybe not http/1.1. Is that acceptable? (I really don't understand this area very well.)

That would be ideal, I'm not sure if http/1.1 would support the streams, and websockets offer more flexibility / lower latency.

@LarryRuane There may also be interest in calling these RPCs from a serverless environment where websockets don't work well, so adding regular http/1.1 REST endpoints would be valuable too.

arya2 avatar Nov 16 '23 19:11 arya2

I asked chatGPT about this -- did I ask the question correctly? chat.openai.com/share/02a1ba5b-217f-42a4-986d-d191f70866c3

It seems to suggest supporting websocket but maybe not http/1.1. Is that acceptable? (I really don't understand this area very well.)

ChatGPT prioritises giving confident answers over correct answers, so I'd encourage you to check those answers with StackOverflow or the Go library reference, and test that all the RPCs work.

Here's some background on ChatGPT's lack of reliability - a study found that ChatGPT got code questions wrong 52% of the time: https://www.theregister.com/2023/08/07/chatgpt_stack_overflow_ai/

teor2345 avatar Nov 16 '23 19:11 teor2345

Is this still being worked on? @LarryRuane

ec2 avatar Sep 19 '24 15:09 ec2