lightwalletd icon indicating copy to clipboard operation
lightwalletd copied to clipboard

Published 20 hours ago • verified publisher icon zcash

Implement ZIP 244 txid logic for v5 transactions

Open str4d opened this issue 2 years ago • 3 comments

Support for parsing v5 transactions (as specified in ZIP 225) was added in #367. However, the txid computation for v5 transactions (as specified in ZIP 244) was not implemented. This means that at present, lightwalletd returns incorrect txids for v5 transactions in compact blocks:

https://github.com/zcash/lightwalletd/blob/ab4c0fef70dcb195f131d3d794e0c9cec2972dba/common/common.go#L261-L274

https://github.com/zcash/lightwalletd/blob/ab4c0fef70dcb195f131d3d794e0c9cec2972dba/parser/block.go#L108-L127

https://github.com/zcash/lightwalletd/blob/ab4c0fef70dcb195f131d3d794e0c9cec2972dba/parser/transaction.go#L379-L383

https://github.com/zcash/lightwalletd/blob/ab4c0fef70dcb195f131d3d794e0c9cec2972dba/parser/transaction.go#L346-L365

str4d avatar May 23 '22 18:05 str4d